From: Yongseok Koh <yskoh@mellanox.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: "Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call
Date: Fri, 28 Jul 2017 00:26:54 +0000 [thread overview]
Message-ID: <55700E85-9A8D-419A-AE1A-63EBB26B0F18@mellanox.com> (raw)
In-Reply-To: <cfdb1356-9fc6-f4ec-34c6-3ec1ff571207@grimberg.me>
> On Jul 27, 2017, at 4:12 AM, Sagi Grimberg <sagi@grimberg.me> wrote:
>
>
>>> Yes I realize that, but can't the device still complete in a burst (of
>>> unsuppressed completions)? I mean its not guaranteed that for every
>>> txq_complete a signaled completion is pending right? What happens if
>>> the device has inconsistent completion pacing? Can't the sw grow a
>>> batch of completions if txq_complete will process a single completion
>>> unconditionally?
>> Speculation. First of all, device doesn't delay completion notifications for no
>> reason. ASIC is not a SW running on top of a OS.
>
> I'm sorry but this statement is not correct. It might be correct in a
> lab environment, but in practice, there are lots of things that can
> affect the device timing.
Disagree.
[...]
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Thanks for ack!
Yongseok
next prev parent reply other threads:[~2017-07-28 0:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 15:48 Yongseok Koh
2017-07-20 16:34 ` Sagi Grimberg
2017-07-21 15:10 ` Yongseok Koh
2017-07-23 9:49 ` Sagi Grimberg
2017-07-25 7:43 ` Yongseok Koh
2017-07-27 11:12 ` Sagi Grimberg
2017-07-28 0:26 ` Yongseok Koh [this message]
2017-07-31 16:12 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55700E85-9A8D-419A-AE1A-63EBB26B0F18@mellanox.com \
--to=yskoh@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).