From: "Simon Kågström" <simon.kagstrom@netinsight.net>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time
Date: Fri, 05 Jun 2015 08:01:20 +0200 [thread overview]
Message-ID: <55713B30.8030000@netinsight.net> (raw)
In-Reply-To: <AAC06825A3B29643AF5372F5E0DDF053350F01FE@IRSMSX106.ger.corp.intel.com>
<Snipping lots of stuff>
On 2015-06-04 23:27, Chilikin, Andrey wrote:
>> Its not a bad addition, I'm just not sure its worth having to take on the
>> additional API surface to include. I'd be more supportive if you could enhance
>> the function to allow the previously mentioned before/after flexibiilty. Then we
>> could just deprecate rte_eal_init as an API call entirely, and use this instead.
>
> Before/after would be very useful, a lot of applications use only "-c" and "-n" EAL command line parameters and "-c" in many cases is redundant as application can calculate core mask from its own parameters, and "-n" just a required parameter which can be defaulted to a platform specific value. So in addition to rte_set_application_usage_hook() it would be nice to have some more general way of overwriting eal initialization parameters.
I've always found it a bit strange that DPDK forces argv handling this
way. The application will anyway have to setup system-specific stuff
(buffer count etc) for the ports to use, so special-casing memory and
core setup seems strange. I think it would be more logical to have EAL
configuration from a structure like for the ports:
struct dpdk_conf conf =
{
.core_mask = 0x7,
.huge_pages = 1,
[...]
};
rte_eal_init(&conf);
And make the current argv parser optional, i.e., something like
int main(argc, argv)
{
struct dpdk_conf conf;
ret = rte_eal_parse_argv(&conf);
rte_eal_init(&conf);
argc -= ret; ...
}
// Simon
prev parent reply other threads:[~2015-06-05 6:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 18:49 Keith Wiles
2015-06-03 19:24 ` Thomas Monjalon
2015-06-03 19:43 ` Wiles, Keith
2015-06-04 0:12 ` Stephen Hemminger
2015-06-04 11:50 ` Wiles, Keith
2015-06-04 13:55 ` Neil Horman
2015-06-04 14:27 ` Wiles, Keith
2015-06-04 14:43 ` David Marchand
2015-06-04 14:51 ` Wiles, Keith
2015-06-04 14:55 ` Wiles, Keith
2015-06-04 14:47 ` Stephen Hemminger
2015-06-04 16:51 ` Thomas F Herbert
2015-06-04 21:27 ` Chilikin, Andrey
2015-06-05 6:01 ` Simon Kågström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55713B30.8030000@netinsight.net \
--to=simon.kagstrom@netinsight.net \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).