DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz@6wind.com>
To: Maxim Uvarov <maxim.uvarov@linaro.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] dpdk1.7.1 rte.app.mk add options not not build targerts
Date: Tue, 09 Jun 2015 14:05:35 +0200	[thread overview]
Message-ID: <5576D68F.7040804@6wind.com> (raw)
In-Reply-To: <1433844953-29887-1-git-send-email-maxim.uvarov@linaro.org>

Hello Maxim,

On 06/09/2015 12:15 PM, Maxim Uvarov wrote:
> Inherit build varibles only so that this file can be included
> from other projects.
>
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

Can you detail a bit more what you want to do?
Why do you need to include rte.app.mk? This file is
internal to the dpdk framework.

By the way, the title is not understandable:
- why dpdk1.7.1 ?
- targerts -> targets
- not not ?

Regards,
Olivier


> ---
>   mk/rte.app.mk | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 34dff2a..b75925d 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -222,6 +222,7 @@ endif # ifeq ($(NO_AUTOLIBS),)
>
>   LDLIBS += $(CPU_LDLIBS)
>
> +ifneq ($(DPRK_APP_MK_SKIP_BUILD_TARGETS),1)
>   .PHONY: all
>   all: install
>
> @@ -232,6 +233,7 @@ _postinstall: build
>
>   .PHONY: build
>   build: _postbuild
> +endif
>
>   exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))
>
> @@ -306,6 +308,7 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP)
>   	@[ -d $(RTE_OUTPUT)/app ] || mkdir -p $(RTE_OUTPUT)/app
>   	$(Q)cp -f $(APP).map $(RTE_OUTPUT)/app
>
> +ifneq ($(DPRK_APP_MK_SKIP_BUILD_TARGETS), 1)
>   #
>   # Clean all generated files
>   #
> @@ -317,7 +320,7 @@ clean: _postclean
>   doclean:
>   	$(Q)rm -rf $(APP) $(OBJS-all) $(DEPS-all) $(DEPSTMP-all) \
>   	  $(CMDS-all) $(INSTALL-FILES-all) .$(APP).cmd
> -
> +endif
>
>   include $(RTE_SDK)/mk/internal/rte.compile-post.mk
>   include $(RTE_SDK)/mk/internal/rte.install-post.mk
>

  reply	other threads:[~2015-06-09 12:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09 10:15 Maxim Uvarov
2015-06-09 12:05 ` Olivier MATZ [this message]
2015-06-09 12:59   ` Maxim Uvarov
2015-06-09 14:37     ` Olivier MATZ
2015-06-09 15:29       ` Maxim Uvarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5576D68F.7040804@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=maxim.uvarov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).