From: Panu Matilainen <pmatilai@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] acl: mark deprecated functions
Date: Wed, 17 Jun 2015 10:59:26 +0300 [thread overview]
Message-ID: <558128DE.9060802@redhat.com> (raw)
In-Reply-To: <1434387073-16951-4-git-send-email-stephen@networkplumber.org>
On 06/15/2015 07:51 PM, Stephen Hemminger wrote:
> From: Stephen Hemminger <shemming@brocade.com>
>
> To allow for compatiablity with later releases, any functions
> to be removed should be marked as deprecated for one release.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
[...]
> diff --git a/lib/librte_acl/rte_acl.h b/lib/librte_acl/rte_acl.h
> index 3a93730..0c32df0 100644
> --- a/lib/librte_acl/rte_acl.h
> +++ b/lib/librte_acl/rte_acl.h
> @@ -456,7 +456,7 @@ enum {
> int
> rte_acl_ipv4vlan_add_rules(struct rte_acl_ctx *ctx,
> const struct rte_acl_ipv4vlan_rule *rules,
> - uint32_t num);
> + uint32_t num) __attribute__((deprecated));
>
> /**
> * Analyze set of ipv4vlan rules and build required internal
> @@ -478,7 +478,7 @@ rte_acl_ipv4vlan_add_rules(struct rte_acl_ctx *ctx,
> int
> rte_acl_ipv4vlan_build(struct rte_acl_ctx *ctx,
> const uint32_t layout[RTE_ACL_IPV4VLAN_NUM],
> - uint32_t num_categories);
> + uint32_t num_categories) __attribute__((deprecated));
>
>
> #ifdef __cplusplus
>
I've no objections to the patch as such, but I think the ABI policy is
asking all deprecation notices to be added to the "Deprecation Notices"
section in the policy document itself.
That said, the average developer is MUCH likelier to notice the compiler
warning from these than a deprecation notice in some "who reads those"
document :) Perhaps we could generate a list of functions marked for
removal for the ABI policy document automatically based on the
deprecated attributes.
- Panu -
next prev parent reply other threads:[~2015-06-17 7:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 16:51 [dpdk-dev] [PATCH 0/3 v2] remove code marked as deprecated in 2.0 Stephen Hemminger
2015-06-15 16:51 ` [dpdk-dev] [PATCH 1/3] pmd_ring: remove deprecated functions Stephen Hemminger
2015-06-16 13:52 ` Bruce Richardson
2015-06-16 23:05 ` Stephen Hemminger
2015-06-16 23:37 ` Thomas Monjalon
[not found] ` <2d83a4d8845f4daa90f0ccafbed918e3@BRMWP-EXMB11.corp.brocade.com>
2015-06-17 0:39 ` Stephen Hemminger
2015-06-17 7:29 ` Panu Matilainen
2015-06-15 16:51 ` [dpdk-dev] [PATCH 2/3] kni: " Stephen Hemminger
2015-06-15 16:51 ` [dpdk-dev] [PATCH 3/3] acl: mark " Stephen Hemminger
2015-06-17 7:59 ` Panu Matilainen [this message]
2015-08-16 22:51 ` [dpdk-dev] [PATCH 0/3] announce deprecation of functions commented as deprecated Thomas Monjalon
2015-08-16 22:51 ` [dpdk-dev] [PATCH 1/3] doc: announce legacy 7-tuple acl rule removal Thomas Monjalon
2015-08-16 22:51 ` [dpdk-dev] [PATCH 2/3] doc: announce removal of kni functions using port id Thomas Monjalon
2015-08-16 22:51 ` [dpdk-dev] [PATCH 3/3] doc: announce ring PMD functions removal Thomas Monjalon
2015-08-17 14:42 ` [dpdk-dev] [PATCH 0/3] announce deprecation of functions commented as deprecated Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2015-06-12 5:18 [dpdk-dev] [PATCH 0/3] do deprecation in 2.1 Stephen Hemminger
2015-06-12 5:18 ` [dpdk-dev] [PATCH 3/3] acl: mark deprecated functions Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558128DE.9060802@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).