From: Tetsuya Mukawa <mukawa@igel.co.jp>
To: Ravi Kerur <rkerur@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] Change rte_eal_vdev_init to update port_id
Date: Mon, 10 Aug 2015 14:31:51 +0900 [thread overview]
Message-ID: <55C83747.7080902@igel.co.jp> (raw)
In-Reply-To: <CAFb4SLDLin+h8u8d5VNHPgxv_vQQn_3sHk1+2HKkHcQeeG-njw@mail.gmail.com>
On 2015/08/08 7:06, Ravi Kerur wrote:
> Hi Tetsuya,
>
> On Thu, Aug 6, 2015 at 7:25 PM, Tetsuya Mukawa <mukawa@igel.co.jp
> <mailto:mukawa@igel.co.jp>> wrote:
>
> On 2015/08/07 3:04, Ravi Kerur wrote:
> > diff --git a/drivers/net/enic/enic_ethdev.c
> b/drivers/net/enic/enic_ethdev.c
> > index 8280cea..472ef5a 100644
> > --- a/drivers/net/enic/enic_ethdev.c
> > +++ b/drivers/net/enic/enic_ethdev.c
> > @@ -36,8 +36,8 @@
> > #include <stdio.h>
> > #include <stdint.h>
> >
> > -#include <rte_dev.h>
> > #include <rte_pci.h>
> > +#include <rte_dev.h>
> > #include <rte_ethdev.h>
> > #include <rte_string_fns.h>
>
> Hi Ravi,
>
> Do we need this fixing?
>
> >
> > diff --git a/drivers/net/mpipe/mpipe_tilegx.c
> b/drivers/net/mpipe/mpipe_tilegx.c
> > index 743feef..6e3e304 100644
> > --- a/drivers/net/mpipe/mpipe_tilegx.c
> > +++ b/drivers/net/mpipe/mpipe_tilegx.c
> > @@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname,
> > if (!eth_dev) {
> > RTE_LOG(ERR, PMD, "%s: Failed to allocate
> device.\n", ifname);
> > rte_free(priv);
> > + return -ENOMEM;
>
> How about separating this fixing from the patch, and put it as an
> one of
> cleanup patch series?
>
>
> rte_pmd_mpipe_devinit is the init func pointer called via
> rte_eal_vdev_init. Since we were fixing rte_eal_vdev_init thought of
> taking care of mpipe issue. If you think it's unrelated to this patch
> I will send a separate one.
>
Hi Ravi,
To avoid segmentation fault like above has a point, even if rest of this
patch won't be applied.
So I guess it's nice to separate the patch.
Thanks,
Tetsuya
prev parent reply other threads:[~2015-08-10 5:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 18:04 Ravi Kerur
2015-08-07 2:25 ` Tetsuya Mukawa
2015-08-07 22:06 ` Ravi Kerur
2015-08-09 9:21 ` Thomas Monjalon
2015-08-10 5:31 ` Tetsuya Mukawa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C83747.7080902@igel.co.jp \
--to=mukawa@igel.co.jp \
--cc=dev@dpdk.org \
--cc=rkerur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).