From: Olivier MATZ <olivier.matz@6wind.com>
To: Joongi Kim <joongi@an.kaist.ac.kr>,
Sergey Balabanov <balabanovsv@ecotelecom.ru>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mbuf & mempool: explicit typecast on function return
Date: Mon, 17 Aug 2015 14:50:57 +0200 [thread overview]
Message-ID: <55D1D8B1.1090604@6wind.com> (raw)
In-Reply-To: <CAKOGY8+fxBoySfyWvH4u_eDVrKqFstBC+pNzBXXNjiXLzHT3cw@mail.gmail.com>
Hi Joongi,
On 08/17/2015 02:28 PM, Joongi Kim wrote:
> I already have fixed this issue
> at http://dpdk.org/dev/patchwork/patch/6068/ .
> There is another issue related to "underlying type" for enum
> declarations http://dpdk.org/dev/patchwork/patch/6067/, for C++11 compilers.
>
> In the second patch I missed updating headers for architectures other
> than x86,
> so it needs to be updated before applying to the master branch.
>
> It would be great for me to have this fixed on the master branch,
> as I am manually applying above patches whenever I pull the latest codes.
>
+CC Thomas.
Sorry, I missed your previous patches. I think it would indeed be
helpful to have them included before the release to allow compilation
of C++ programs.
I'm wondering if we should add a C++ example in dpdk/examples: people
would see the problem before commiting, or if they miss it, I know some
people are doing automatic compilation tests every day.
Regards,
Olivier
> Regards,
> Joongi
>
> 2015년 8월 17일 (월) 오후 5:15, Olivier MATZ <olivier.matz@6wind.com
> <mailto:olivier.matz@6wind.com>>님이 작성:
>
> Hi Sergey,
>
> On 08/12/2015 11:11 AM, Sergey Balabanov wrote:
> > When DPDK is being compiled in C++ project using g++ then
> > 'invalid conversion from' error appears. Added explicit
> > typecast on function return to get rid of the error.
> >
> > Signed-off-by: Sergey Balabanov <balabanovsv@ecotelecom.ru
> <mailto:balabanovsv@ecotelecom.ru>>
>
>
> Fixes: 7755baae8378 ("mbuf: silence warning on pointer arithmetic")
> Fixes: 6cf14ce4ce6c ("mempool: silence warning on pointer arithmetic")
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com
> <mailto:olivier.matz@6wind.com>>
>
> Thanks
>
next prev parent reply other threads:[~2015-08-17 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 9:11 Sergey Balabanov
2015-08-17 8:14 ` Olivier MATZ
2015-08-17 12:28 ` Joongi Kim
2015-08-17 12:50 ` Olivier MATZ [this message]
2015-08-17 15:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D1D8B1.1090604@6wind.com \
--to=olivier.matz@6wind.com \
--cc=balabanovsv@ecotelecom.ru \
--cc=dev@dpdk.org \
--cc=joongi@an.kaist.ac.kr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).