From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Kumar, Ravi1" <Ravi1.Kumar@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH 1/4] Add AMD XGBE Ethernet config support in DPDK
Date: Thu, 14 Sep 2017 17:25:31 +0100 [thread overview]
Message-ID: <55a21367-8a63-a5e3-5260-2069bc2095c6@intel.com> (raw)
In-Reply-To: <DM5PR12MB1129F3BBF73F30C3B7137581AE6F0@DM5PR12MB1129.namprd12.prod.outlook.com>
On 9/14/2017 10:48 AM, Kumar, Ravi1 wrote:
>> On 9/13/2017 6:47 PM, Ravi Kumar wrote:
>>> Signed-off-by: Ravi Kumar <ravi1.kumar@amd.com>
>>> ---
>>> config/common_base | 6 ++++++
>>> mk/rte.app.mk | 1 +
>>> 2 files changed, 7 insertions(+)
>>>
>>> diff --git a/config/common_base b/config/common_base index
>>> 5e97a08..fab46b5 100644
>>> --- a/config/common_base
>>> +++ b/config/common_base
>>> @@ -405,6 +405,12 @@ CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y
>>> CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n
>>>
>>> #
>>> +# Compile AMD PMD
>>> +#
>>> +CONFIG_RTE_LIBRTE_AXGBE_PMD=n
>>
>> Hi Ravi,
>>
>> This is a new networking driver from AMD. Great to see new vendors in DPDK, welcome.
>>
>> Patch 2/4 seems missing in the mail list, it may be stuck because of the size limit if it is a big patch, which may mean it needs to be split into multiple patches :)
>>
>> Thanks,
>> ferruh
>
> Hi Ferruh,
>
> Thanks a lot. The Patch 2/4 got posted just now. It will be great to get review comments on the same.
At first glance:
- There is a new licensing, that needs to be approved.
- patch 2/4 is big and hard to review properly, is it possible to have
multiple incremental patches, there are good previous samples of this.
- Can you please update release notes to announce new PMD?
- ICC is giving build error [1], but this can be handled later.
[1]
#pragma GCC diagnostic ignored "-Wcast-qual"
>
> Regards,
> Ravi
<...>
prev parent reply other threads:[~2017-09-14 16:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 17:47 Ravi Kumar
2017-09-13 17:47 ` [dpdk-dev] [PATCH 2/4] net/axgbe : Add PMD support for AMD XGBE Ethernet Ravi Kumar
2017-09-14 16:25 ` Ferruh Yigit
2017-09-15 12:29 ` Kumar, Ravi1
2017-09-13 17:47 ` [dpdk-dev] [PATCH 3/4] doc: Add documents " Ravi Kumar
2017-09-14 11:57 ` Hemant Agrawal
2017-09-14 14:02 ` Kumar, Ravi1
2017-09-15 4:41 ` Hemant Agrawal
2017-09-15 12:26 ` Kumar, Ravi1
2017-11-13 19:20 ` Thomas Monjalon
2017-11-14 6:36 ` Kumar, Ravi1
[not found] ` <DM2PR12MB0138AA6F2C7782A949E2521C9D280@DM2PR12MB0138.namprd12.prod.outlook.com>
2017-11-15 0:07 ` Hemant Agrawal
2017-11-17 17:48 ` Shippen, Greg
2017-11-19 16:09 ` Hemant Agrawal
2017-09-14 16:26 ` Ferruh Yigit
2017-09-18 17:39 ` Mcnamara, John
2017-09-13 17:47 ` [dpdk-dev] [PATCH 4/4] maintainers: add maintainer for AMD AXGBE PMD Ravi Kumar
2017-09-14 16:26 ` Ferruh Yigit
2017-09-14 8:53 ` [dpdk-dev] [PATCH 1/4] Add AMD XGBE Ethernet config support in DPDK Ferruh Yigit
2017-09-14 9:48 ` Kumar, Ravi1
2017-09-14 16:25 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55a21367-8a63-a5e3-5260-2069bc2095c6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Ravi1.Kumar@amd.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).