From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: dpdk-dev <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] malloc: fix duplicate mem event notification
Date: Thu, 29 Nov 2018 15:36:29 +0000 [thread overview]
Message-ID: <55beddff-0c3a-63c0-e793-636265175c75@intel.com> (raw)
In-Reply-To: <D8B27CF4-BE99-4A06-8A94-86853BD480F8@intel.com>
On 29-Nov-18 2:54 PM, Wiles, Keith wrote:
>
>
>> On Nov 29, 2018, at 8:21 AM, Anatoly Burakov <anatoly.burakov@intel.com> wrote:
>>
>> We already trigger a mem event notification inside the walk function,
>> no need to do it twice.
>>
>> Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
>> lib/librte_eal/common/rte_malloc.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c
>> index 0da5ad5e8..750a83c2c 100644
>> --- a/lib/librte_eal/common/rte_malloc.c
>> +++ b/lib/librte_eal/common/rte_malloc.c
>> @@ -518,10 +518,6 @@ sync_memory(const char *heap_name, void *va_addr, size_t len, bool attach)
>> rte_errno = -wa.result;
>> ret = -1;
>> } else {
>> - /* notify all subscribers that a new memory area was added */
>> - if (attach)
>> - eal_memalloc_mem_event_notify(RTE_MEM_EVENT_ALLOC,
>> - va_addr, len);
>> ret = 0;
>> }
>
> This change leaves
> else {
> ret = 0;
> }
>
> Needs to be:
> else
> ret = 0;
>
Checkpatch disagrees :P Brackets are needed everywhere if at least one
of the branches is a multiline branch. No brackets needed only if all
branches are one-line branches.
As a side note, I would also argue that we shouldn't leave bracket-less
if statements altogether, because it makes for extra effort whenever a
single-line statement inevitably becomes a multiline one (e.g. could be
as simple as putting in a debug printf - i now have to add brackets
everywhere...). But that's a topic for another day :)
>
>> unlock:
>> --
>> 2.17.1
>
> Regards,
> Keith
>
>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-11-29 15:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 14:21 [dpdk-stable] " Anatoly Burakov
2018-11-29 14:54 ` [dpdk-stable] [dpdk-dev] " Wiles, Keith
2018-11-29 15:36 ` Burakov, Anatoly [this message]
2018-11-29 15:47 ` Wiles, Keith
2018-11-29 17:05 ` Ferruh Yigit
2018-11-29 15:18 ` [dpdk-stable] " Anatoly Burakov
2018-11-29 15:36 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2018-12-11 16:48 ` [dpdk-stable] [PATCH v2] " Anatoly Burakov
2018-12-20 14:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55beddff-0c3a-63c0-e793-636265175c75@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).