From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] net/netvsc: support receive without vlan strip
Date: Mon, 17 Dec 2018 10:27:03 +0000 [thread overview]
Message-ID: <55cd82b0-47d4-016a-7b9e-bfd512313262@intel.com> (raw)
In-Reply-To: <20181214082844.2b125896@xeon-e3>
On 12/14/2018 4:28 PM, Stephen Hemminger wrote:
> On Fri, 14 Dec 2018 16:09:33 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
>> On 12/14/2018 1:26 AM, Stephen Hemminger wrote:
>>> In some cases, VLAN stripping is not desireable. If necessary
>>> re-insert stripped vlan tag.
>>>
>>> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>>
>> <...>
>>
>>> @@ -501,6 +501,14 @@ static void hn_rxpkt(struct hn_rx_queue *rxq, struct hn_rx_bufinfo *rxb,
>>> if (info->vlan_info != HN_NDIS_VLAN_INFO_INVALID) {
>>> m->vlan_tci = info->vlan_info;
>>> m->ol_flags |= PKT_RX_VLAN_STRIPPED | PKT_RX_VLAN;
>>> +
>>> + /* NDIS always strips tag, put it back if necessary */
>>> + if (!hv->vlan_strip && rte_vlan_insert(&m)) {
>>
>> Should 'PKT_RX_VLAN_STRIPPED' flag removed when vlan inserted back?
>
> This is already done by rte_vlan_insert()
Yes it does, so it is OK.
next prev parent reply other threads:[~2018-12-17 10:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 1:26 [dpdk-dev] [PATCH 0/3] net/netvsc: misc fixes Stephen Hemminger
2018-12-14 1:26 ` [dpdk-dev] [PATCH 1/3] net/netvsc: support receive without vlan strip Stephen Hemminger
2018-12-14 16:09 ` Ferruh Yigit
2018-12-14 16:28 ` Stephen Hemminger
2018-12-17 10:27 ` Ferruh Yigit [this message]
2018-12-14 1:26 ` [dpdk-dev] [PATCH 2/3] net/netvsc: cleanup transmit descriptor pool Stephen Hemminger
2018-12-17 10:46 ` Ferruh Yigit
2018-12-17 22:11 ` Ferruh Yigit
2018-12-14 1:26 ` [dpdk-dev] [PATCH 3/3] net/netvsc: not finding VF should not cause failure Stephen Hemminger
2018-12-17 10:49 ` Ferruh Yigit
[not found] ` <DM5PR21MB0698C89DE76C533F41190931CCBC0@DM5PR21MB0698.namprd21.prod.outlook.com>
2018-12-17 22:11 ` Ferruh Yigit
2018-12-17 22:12 ` Ferruh Yigit
2018-12-17 22:13 ` [dpdk-dev] [PATCH 0/3] net/netvsc: misc fixes Ferruh Yigit
2018-12-18 6:32 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55cd82b0-47d4-016a-7b9e-bfd512313262@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).