From: Olivier MATZ <olivier.matz@6wind.com>
To: Francesco Montorsi <francesco.montorsi@gmail.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Add error message when trying to use make option T= during build/clean
Date: Tue, 13 Oct 2015 15:22:44 +0200 [thread overview]
Message-ID: <561D05A4.2060708@6wind.com> (raw)
In-Reply-To: <1443542682-7088-1-git-send-email-francesco.montorsi@gmail.com>
Hi Francesco,
On 09/29/2015 06:04 PM, Francesco Montorsi wrote:
> From: Francesco Montorsi <fmontorsi@empirix.com>
>
> ---
> mk/rte.sdkbuild.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
> index 38ec7bd..013aa89 100644
> --- a/mk/rte.sdkbuild.mk
> +++ b/mk/rte.sdkbuild.mk
> @@ -29,6 +29,12 @@
> # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> +ifdef T
> + ifeq ("$(origin T)", "command line")
> + $(error "Cannot use T= with a build/clean target")
> + endif
> +endif
> +
> # If DESTDIR variable is given, install binary dpdk
I tested this patch but it breaks the "make install" command:
$ make install T=x86_64-native-linuxapp-gcc
make[5]: Nothing to be done for 'depdirs'.
Configuration done
rte.sdkbuild.mk:34: *** "Cannot use T= with a build/clean target".
As the T= argument is given as a command line variable, it is
propagated to the "$(MAKE) all" in rte.sdkinstall.mk.
So I think it's better to keep the current code as is, except if
you have a better idea.
Regards,
Olivier
next prev parent reply other threads:[~2015-10-13 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 16:04 Francesco Montorsi
2015-10-13 13:22 ` Olivier MATZ [this message]
2015-10-14 8:02 ` Francesco
2015-10-21 19:27 ` Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561D05A4.2060708@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=francesco.montorsi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).