From: "Liang, Cunming" <cunming.liang@intel.com>
To: Yong Liu <yong.liu@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 3/7] e1000: add ethdev rxq enable and disable function
Date: Mon, 26 Oct 2015 15:37:35 +0800 [thread overview]
Message-ID: <562DD83F.8090806@intel.com> (raw)
In-Reply-To: <1443169692-4709-4-git-send-email-yong.liu@intel.com>
On 9/25/2015 4:28 PM, Yong Liu wrote:
> From: Marvin Liu <yong.liu@intel.com>
>
> Implement rxq interrupt related functions in eth_dev_ops structure.
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>
> diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
> index e86c039..2b67b62 100644
> --- a/drivers/net/e1000/em_ethdev.c
> +++ b/drivers/net/e1000/em_ethdev.c
> @@ -108,6 +108,9 @@ static void em_vlan_hw_strip_disable(struct rte_eth_dev *dev);
> static void eth_em_vlan_filter_set(struct rte_eth_dev *dev,
> uint16_t vlan_id, int on);
> */
> +
> +static int eth_em_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id);
> +static int eth_em_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id);
> static void em_lsc_intr_disable(struct e1000_hw *hw);
> static void em_rxq_intr_enable(struct e1000_hw *hw);
> static void em_rxq_intr_disable(struct e1000_hw *hw);
> @@ -163,6 +166,8 @@ static const struct eth_dev_ops eth_em_ops = {
> .rx_descriptor_done = eth_em_rx_descriptor_done,
> .tx_queue_setup = eth_em_tx_queue_setup,
> .tx_queue_release = eth_em_tx_queue_release,
> + .rx_queue_intr_enable = eth_em_rx_queue_intr_enable,
> + .rx_queue_intr_disable = eth_em_rx_queue_intr_disable,
> .dev_led_on = eth_em_led_on,
> .dev_led_off = eth_em_led_off,
> .flow_ctrl_get = eth_em_flow_ctrl_get,
> @@ -891,6 +896,27 @@ eth_em_stats_reset(struct rte_eth_dev *dev)
> memset(hw_stats, 0, sizeof(*hw_stats));
> }
>
> +static int
> +eth_em_rx_queue_intr_enable(struct rte_eth_dev *dev, __attribute__((__unused__))uint16_t queue_id)
Suggest to use __rte_unused instead of __attribute__((__unused__)).
> +{
> + struct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +
> + em_rxq_intr_enable(hw);
> + rte_intr_enable(&(dev->pci_dev->intr_handle));
> +
> + return 0;
> +}
> +
> +static int
> +eth_em_rx_queue_intr_disable(struct rte_eth_dev *dev, __attribute__((__unused__))uint16_t queue_id)
The same.
> +{
> + struct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +
> + em_rxq_intr_disable(hw);
> +
> + return 0;
> +}
> +
> static uint32_t
> em_get_max_pktlen(const struct e1000_hw *hw)
> {
next prev parent reply other threads:[~2015-10-26 7:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 8:28 [dpdk-dev] [PATCH v1 0/7] interrupt mode for e1000 Yong Liu
2015-09-25 8:28 ` [dpdk-dev] [PATCH v1 1/7] e1000: add rx interrupt support Yong Liu
2015-10-26 7:35 ` Liang, Cunming
2015-10-27 14:48 ` Liu, Yong
2015-09-25 8:28 ` [dpdk-dev] [PATCH v1 2/7] e1000: separate lsc and rxq interrupt function Yong Liu
2015-09-25 8:28 ` [dpdk-dev] [PATCH v1 3/7] e1000: add ethdev rxq enable and disable function Yong Liu
2015-10-26 7:37 ` Liang, Cunming [this message]
2015-09-25 8:28 ` [dpdk-dev] [PATCH v1 4/7] e1000: add rxq interrupt handler Yong Liu
2015-09-25 8:28 ` [dpdk-dev] [PATCH v1 5/7] e1000: check lsc and rxq not enable in the same time Yong Liu
2015-09-25 8:28 ` [dpdk-dev] [PATCH v1 6/7] e1000: lsc interrupt setup only enable itself Yong Liu
2015-09-25 8:28 ` [dpdk-dev] [PATCH v1 7/7] l3fwd-power: disable interrupt when wake up from sleep Yong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562DD83F.8090806@intel.com \
--to=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).