From: Panu Matilainen <pmatilai@redhat.com>
To: dev@dpdk.org, Eric Kinzie <ekinzie@brocade.com>
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix ABI versioning compile error for combined shared library
Date: Tue, 3 Nov 2015 12:41:10 +0200 [thread overview]
Message-ID: <56388F46.7040405@redhat.com> (raw)
In-Reply-To: <20151103092033.GA16414@sivlogin002.ir.intel.com>
On 11/03/2015 11:20 AM, Ferruh Yigit wrote:
> On Tue, Nov 03, 2015 at 09:06:05AM +0200, Panu Matilainen wrote:
>> On 11/02/2015 05:23 PM, Ferruh Yigit wrote:
>>> Fixes following error:
>>> LD libdpdk.so
>>> /usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found
>>> for symbol <function>@DPDK_x.y
>>>
>>> Defines version symbols in a fixed path libdpdk.map file and this
>>> value hardcoded into makefile
>>
>> Hold on. What problem is this supposed to be fixing?
> This patch is to fix combined library compilation error when ABI versining used.
> Currently if ABI version macros used (VERSION_SYMBOL), we are not able to compile combined shared library.
>
>> If its for the bonding thing (as it'd appear from the threading), NAK.
> Nothing directly related to the bonding, just issue observed in this thread.
Okay, understood, it was just not clear from the description. Since
there are no users of VERSION_SYMBOL etc macros this error has not come
up until now.
>
>> The symbol versioning in
>> that patch is confused needs to be fixed there instead of inventing strange
>> workarounds elsewhere.
>>
> This is not intented to be a workaround but a fix, unless you have a better idea.
The problem is, it undoes the other benefit of symbol versioning: hiding
the internal symbols. So in my eyes its more of a hack or a workaround
than a fix.
I'd much much rather see this as a solution:
http://dpdk.org/dev/patchwork/patch/4262/
- Panu -
>
>
next prev parent reply other threads:[~2015-11-03 10:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 15:36 [dpdk-dev] [PATCH v6 0/4] bonding corrections and additions Eric Kinzie
2015-10-19 15:36 ` [dpdk-dev] [PATCH v6 1/4] bond mode 4: copy entire config structure Eric Kinzie
2015-10-19 15:36 ` [dpdk-dev] [PATCH v6 2/4] bond mode 4: do not ignore multicast Eric Kinzie
2015-10-19 15:36 ` [dpdk-dev] [PATCH v6 3/4] bond mode 4: allow external state machine Eric Kinzie
2015-11-01 18:17 ` Thomas Monjalon
2015-11-01 23:17 ` [dpdk-dev] [PATCH] mk: fix ABI versioning compile error for combined shared library Ferruh Yigit
2015-11-01 23:24 ` Thomas Monjalon
2015-11-02 0:05 ` Ferruh Yigit
2015-11-02 7:10 ` Thomas Monjalon
2015-11-02 10:20 ` Ferruh Yigit
2015-11-02 15:23 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2015-11-02 16:26 ` Thomas Monjalon
2015-11-02 19:18 ` Ferruh Yigit
2015-11-03 7:06 ` Panu Matilainen
2015-11-03 9:20 ` Ferruh Yigit
2015-11-03 10:41 ` Panu Matilainen [this message]
2015-11-03 11:33 ` Ferruh Yigit
2015-11-03 11:43 ` Panu Matilainen
2015-11-06 13:58 ` [dpdk-dev] [PATCH] " Ferruh Yigit
2015-11-06 13:58 ` Ferruh Yigit
2015-11-02 10:23 ` [dpdk-dev] [PATCH v6 3/4] bond mode 4: allow external state machine Panu Matilainen
2015-11-02 16:42 ` Eric Kinzie
2015-11-03 6:48 ` Panu Matilainen
2015-11-03 8:16 ` Thomas Monjalon
2015-11-03 8:30 ` Panu Matilainen
2015-11-03 9:38 ` Thomas Monjalon
2015-11-03 17:12 ` Eric Kinzie
2015-11-03 11:02 ` Ferruh Yigit
2015-11-03 11:31 ` Panu Matilainen
2015-11-03 11:48 ` Ferruh Yigit
2015-11-20 19:46 ` Eric Kinzie
2015-11-24 14:52 ` Panu Matilainen
2015-10-19 15:36 ` [dpdk-dev] [PATCH v6 4/4] bond mode 4: tests for " Eric Kinzie
2015-10-19 16:27 ` [dpdk-dev] [PATCH v6 0/4] bonding corrections and additions Declan Doherty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56388F46.7040405@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=ekinzie@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).