From: Olivier MATZ <olivier.matz@6wind.com>
To: Declan Doherty <declan.doherty@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix compilation for icc version 16
Date: Fri, 20 Nov 2015 16:34:48 +0100 [thread overview]
Message-ID: <564F3D98.9060708@6wind.com> (raw)
In-Reply-To: <1448030073-30711-1-git-send-email-declan.doherty@intel.com>
Hi,
On 11/20/2015 03:34 PM, Declan Doherty wrote:
> This patch changes the ICC conditional check to disable
> -no-inline-max-size and -no-inline-max-total-size to be
> for all versions of icc greater than 14 and not just for version 15.
>
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> ---
> mk/toolchain/icc/rte.vars.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
> index e39d710..9b6b34b 100644
> --- a/mk/toolchain/icc/rte.vars.mk
> +++ b/mk/toolchain/icc/rte.vars.mk
> @@ -74,8 +74,8 @@ WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527
>
> # process cpu flags
> include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk
> -# disable max-inline params boundaries for ICC 15 compiler
> -ifeq ($(shell test $(ICC_MAJOR_VERSION) -eq 15 && echo 1), 1)
> +# disable max-inline params boundaries for ICC compiler for version 15 and greater
> +ifeq ($(shell test $(ICC_MAJOR_VERSION) -ge 14 && echo 1), 1)
> TOOLCHAIN_CFLAGS += -no-inline-max-size -no-inline-max-total-size
> endif
>
>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2015-11-20 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 14:34 Declan Doherty
2015-11-20 15:34 ` Olivier MATZ [this message]
2015-11-20 16:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F3D98.9060708@6wind.com \
--to=olivier.matz@6wind.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).