From: Panu Matilainen <pmatilai@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, declan.doherty@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] cryptodev: mark experimental state
Date: Thu, 26 Nov 2015 09:39:09 +0200 [thread overview]
Message-ID: <5656B71D.7030704@redhat.com> (raw)
In-Reply-To: <1448473135-19604-1-git-send-email-thomas.monjalon@6wind.com>
On 11/25/2015 07:38 PM, Thomas Monjalon wrote:
> The crypto API is in an early state.
> It requires more discussions and experiments to declare it stable,
> as discussed in http://dpdk.org/ml/archives/dev/2015-November/028634.html
>
> A documentation section will be required in the guides.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
[...]
> --- a/config/common_bsdapp
> +++ b/config/common_bsdapp
> @@ -310,6 +310,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=y
>
> #
> # Compile generic crypto device library
> +# EXPERIMENTAL: API may change without prior notice
> #
> CONFIG_RTE_LIBRTE_CRYPTODEV=y
> CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
> diff --git a/config/common_linuxapp b/config/common_linuxapp
> index eaad8d6..2866986 100644
> --- a/config/common_linuxapp
> +++ b/config/common_linuxapp
> @@ -319,6 +319,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=y
>
> #
> # Compile generic crypto device library
> +# EXPERIMENTAL: API may change without prior notice
> #
> CONFIG_RTE_LIBRTE_CRYPTODEV=y
> CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
[...]
I think an experimental library which declares itself exempt from the
ABI policy should not be compiled by default. That way anybody wanting
to try it out will be forced to notice the experimental status.
More generally / longer term, perhaps there should be a
CONFIG_RTE_EXPERIMENTAL which wraps all experimental features and
defaults to off.
- Panu -
next prev parent reply other threads:[~2015-11-26 7:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 17:38 Thomas Monjalon
2015-11-25 20:59 ` Thomas Monjalon
2015-11-26 7:39 ` Panu Matilainen [this message]
2015-11-26 8:00 ` Panu Matilainen
2015-11-26 10:08 ` Thomas Monjalon
2015-11-26 13:51 ` Doherty, Declan
2015-11-27 13:09 ` Panu Matilainen
2015-11-27 13:30 ` Thomas Monjalon
2015-12-11 23:34 ` [dpdk-dev] [PATCH] mbuf_offload: " Thomas Monjalon
2015-12-11 23:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5656B71D.7030704@redhat.com \
--to=pmatilai@redhat.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).