From: Panu Matilainen <pmatilai@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: remove old flow director symbols
Date: Tue, 15 Dec 2015 13:41:53 +0200 [thread overview]
Message-ID: <566FFC81.2010601@redhat.com> (raw)
In-Reply-To: <1450176434-7213-2-git-send-email-thomas.monjalon@6wind.com>
On 12/15/2015 12:47 PM, Thomas Monjalon wrote:
> The API has been removed but the symbols were still declared in the map.
>
> Fixes: a421b86a4a02 ("ethdev: remove old flow director API")
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> lib/librte_ether/rte_ether_version.map | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
> index 17a11c7..d8db24d 100644
> --- a/lib/librte_ether/rte_ether_version.map
> +++ b/lib/librte_ether/rte_ether_version.map
> @@ -27,14 +27,6 @@ DPDK_2.2 {
> rte_eth_dev_count;
> rte_eth_dev_default_mac_addr_set;
> rte_eth_dev_detach;
> - rte_eth_dev_fdir_add_perfect_filter;
> - rte_eth_dev_fdir_add_signature_filter;
> - rte_eth_dev_fdir_get_infos;
> - rte_eth_dev_fdir_remove_perfect_filter;
> - rte_eth_dev_fdir_remove_signature_filter;
> - rte_eth_dev_fdir_set_masks;
> - rte_eth_dev_fdir_update_perfect_filter;
> - rte_eth_dev_fdir_update_signature_filter;
> rte_eth_dev_filter_ctrl;
> rte_eth_dev_filter_supported;
> rte_eth_dev_flow_ctrl_get;
>
Good spotting. What did you use find these and the ones in eal? Just
thinking this seems like something that could and should be automated.
- Panu -
next prev parent reply other threads:[~2015-12-15 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 10:47 [dpdk-dev] [PATCH 1/2] eal: remove zombie symbols Thomas Monjalon
2015-12-15 10:47 ` [dpdk-dev] [PATCH 2/2] ethdev: remove old flow director symbols Thomas Monjalon
2015-12-15 11:41 ` Panu Matilainen [this message]
2015-12-15 12:15 ` Thomas Monjalon
2015-12-15 12:53 ` Thomas Monjalon
2015-12-15 14:28 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566FFC81.2010601@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).