From: Thomas Monjalon <thomas@monjalon.net>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
Cc: ferruh.yigit@intel.com, olivier.matz@6wind.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print
Date: Tue, 21 Nov 2017 14:30:48 +0100 [thread overview]
Message-ID: <5684106.7xpmVRmQS0@xps> (raw)
In-Reply-To: <20171121111416.yffsbci3cswwpzx5@Pavan-LT>
21/11/2017 12:14, Pavan Nikhilesh Bhagavatula:
> On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote:
> > 20/11/2017 19:40, Ferruh Yigit:
> > > And, since you are touching these files :),
> > > for better regex support, it may be good to have log types hierarchical, like
> > > "lib.mbuf", "lib.mempool", "lib.eal.malloc", as done in member library but with
> > > "lib" prefix instead of "librte", if this makes sense and you have time would
> > > you mind sending a patch for this as well?
> >
> > I am not sure about using eal in the library names.
> > I think lib.malloc is enough and it would allow to move malloc
> > (and other libraries) outside of EAL if needed.
> > We already moved PCI and VDEV outside of EAL. More could be moved.
>
> Does this look good?
>
> static const struct logtype logtype_strings[] = {
> {RTE_LOGTYPE_EAL, "lib.eal"},
> {RTE_LOGTYPE_MALLOC, "lib.malloc"},
> {RTE_LOGTYPE_RING, "lib.ring"},
> {RTE_LOGTYPE_MEMPOOL, "lib.mempool"},
> {RTE_LOGTYPE_TIMER, "lib.timer"},
> {RTE_LOGTYPE_PMD, "pmd"},
> {RTE_LOGTYPE_HASH, "lib.hash"},
> {RTE_LOGTYPE_LPM, "lib.lpm"},
> {RTE_LOGTYPE_KNI, "lib.kni"},
> {RTE_LOGTYPE_ACL, "lib.acl"},
> {RTE_LOGTYPE_POWER, "lib.power"},
> {RTE_LOGTYPE_METER, "lib.meter"},
> {RTE_LOGTYPE_SCHED, "lib.sched"},
> {RTE_LOGTYPE_PORT, "lib.port"},
> {RTE_LOGTYPE_TABLE, "lib.table"},
> {RTE_LOGTYPE_PIPELINE, "lib.pipeline"},
> {RTE_LOGTYPE_MBUF, "lib.mbuf"},
> {RTE_LOGTYPE_CRYPTODEV, "lib.cryptodev"},
> {RTE_LOGTYPE_EFD, "lib.efd"},
> {RTE_LOGTYPE_EVENTDEV, "lib.eventdev"},
> {RTE_LOGTYPE_GSO, "lib.gso"},
> {RTE_LOGTYPE_USER1, "user1"},
> {RTE_LOGTYPE_USER2, "user2"},
> {RTE_LOGTYPE_USER3, "user3"},
> {RTE_LOGTYPE_USER4, "user4"},
> {RTE_LOGTYPE_USER5, "user5"},
> {RTE_LOGTYPE_USER6, "user6"},
> {RTE_LOGTYPE_USER7, "user7"},
> {RTE_LOGTYPE_USER8, "user8"}
> };
>
> I will be sending out the patch set soon.
These are only the legacy static log types.
Are you sure you want to change them?
They should be removed when using dynamic logging.
next prev parent reply other threads:[~2017-11-21 13:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 10:31 [dpdk-dev] [PATCH 1/2] eal: fix legacy dynamic logs defaulting to debug Pavan Nikhilesh
2017-11-16 10:31 ` [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print Pavan Nikhilesh
2017-11-16 19:48 ` Ferruh Yigit
2017-11-17 8:47 ` Pavan Nikhilesh Bhagavatula
2017-11-20 18:40 ` Ferruh Yigit
2017-11-21 8:30 ` Pavan Nikhilesh Bhagavatula
2017-11-21 10:55 ` Thomas Monjalon
2017-11-21 11:14 ` Pavan Nikhilesh Bhagavatula
2017-11-21 13:30 ` Thomas Monjalon [this message]
2017-11-21 14:04 ` Pavan Nikhilesh Bhagavatula
2017-11-21 18:10 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5684106.7xpmVRmQS0@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).