From: Panu Matilainen <pmatilai@redhat.com>
To: "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>,
"Kerlin, MarcinX" <marcinx.kerlin@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH V1 1/1] jobstats: added function abort for job
Date: Thu, 28 Jan 2016 09:41:06 +0200 [thread overview]
Message-ID: <56A9C612.3080502@redhat.com> (raw)
In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB158213A1DC96@IRSMSX109.ger.corp.intel.com>
On 01/27/2016 05:57 PM, Jastrzebski, MichalX K wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
>> Sent: Wednesday, January 27, 2016 2:38 PM
>> To: Kerlin, MarcinX <marcinx.kerlin@intel.com>; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH V1 1/1] jobstats: added function abort for job
>>
>> On 01/26/2016 06:15 PM, Marcin Kerlin wrote:
>>> This patch adds new function rte_jobstats_abort. It marks *job* as finished
>>> and time of this work will be add to management time instead of execution
>> time.
>>> This function should be used instead of rte_jobstats_finish if condition
>> occure,
>>> condition is defined by the application for example when receiving n>0
>> packets.
>>>
>>> Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>
>>> ---
>>> lib/librte_jobstats/rte_jobstats.c | 22 ++++++++++++++++++++++
>>> lib/librte_jobstats/rte_jobstats.h | 17 +++++++++++++++++
>>> lib/librte_jobstats/rte_jobstats_version.map | 7 +++++++
>>> 3 files changed, 46 insertions(+)
>>>
>> [...]
>>> diff --git a/lib/librte_jobstats/rte_jobstats.h
>> b/lib/librte_jobstats/rte_jobstats.h
>>> index de6a89a..9995319 100644
>>> --- a/lib/librte_jobstats/rte_jobstats.h
>>> +++ b/lib/librte_jobstats/rte_jobstats.h
>>> @@ -90,6 +90,9 @@ struct rte_jobstats {
>>> uint64_t exec_cnt;
>>> /**< Execute count. */
>>>
>>> + uint64_t last_job_time;
>>> + /**< Last job time */
>>> +
>>> char name[RTE_JOBSTATS_NAMESIZE];
>>> /**< Name of this job */
>>>
>>
>> AFAICS this is an ABI break and as such, needs to be preannounced, see
>> http://dpdk.org/doc/guides/contributing/versioning.html
>> For 2.3 it'd need to be a CONFIG_RTE_NEXT_ABI feature.
>>
>> - Panu -
>
> Hi Panu,
> Thanks for Your notice. This last_job_time field is actually not necessary here
> and will be removed from this structure.
Right, makes sense. You can always add it later on when there's a more
pressing need to break the ABI.
- Panu -
next prev parent reply other threads:[~2016-01-28 7:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 16:15 Marcin Kerlin
2016-01-27 13:37 ` Panu Matilainen
2016-01-27 15:57 ` Jastrzebski, MichalX K
2016-01-28 7:41 ` Panu Matilainen [this message]
2016-01-29 15:31 ` [dpdk-dev] [PATCH v2 " Marcin Kerlin
2016-02-12 16:04 ` [dpdk-dev] [PATCH v3 " Marcin Kerlin
2016-02-16 13:19 ` Zhang, Roy Fan
2016-02-29 10:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A9C612.3080502@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=marcinx.kerlin@intel.com \
--cc=michalx.k.jastrzebski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).