From: Tetsuya Mukawa <mukawa@igel.co.jp>
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Cc: "Nicolás Pernas Maradei" <nicolas.pernas.maradei@emutex.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] null: remove duplicate fields in internal data struct
Date: Wed, 3 Feb 2016 15:21:16 +0900 [thread overview]
Message-ID: <56B19C5C.20800@igel.co.jp> (raw)
In-Reply-To: <1454087782-15085-4-git-send-email-ferruh.yigit@intel.com>
On 2016/01/30 2:16, Ferruh Yigit wrote:
> 1- remove duplicate nb_rx/tx_queues fields from internals
> 2- remove duplicate numa_node field from internals
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> drivers/net/null/rte_eth_null.c | 36 ++++++++++++------------------------
> 1 file changed, 12 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index 77fc988..1c354ad 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -69,10 +69,6 @@ struct null_queue {
> struct pmd_internals {
> unsigned packet_size;
> unsigned packet_copy;
> - unsigned numa_node;
> -
> - unsigned nb_rx_queues;
> - unsigned nb_tx_queues;
>
> struct null_queue rx_null_queues[RTE_MAX_QUEUES_PER_PORT];
> struct null_queue tx_null_queues[RTE_MAX_QUEUES_PER_PORT];
> @@ -192,13 +188,8 @@ eth_null_copy_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
> }
>
> static int
> -eth_dev_configure(struct rte_eth_dev *dev) {
> - struct pmd_internals *internals;
> -
> - internals = dev->data->dev_private;
> - internals->nb_rx_queues = dev->data->nb_rx_queues;
> - internals->nb_tx_queues = dev->data->nb_tx_queues;
> -
> +eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
> +{
> return 0;
> }
>
> @@ -237,7 +228,7 @@ eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,
>
> internals = dev->data->dev_private;
>
> - if (rx_queue_id >= internals->nb_rx_queues)
> + if (rx_queue_id >= dev->data->nb_rx_queues)
> return -ENODEV;
>
> packet_size = internals->packet_size;
> @@ -246,7 +237,7 @@ eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,
> dev->data->rx_queues[rx_queue_id] =
> &internals->rx_null_queues[rx_queue_id];
> dummy_packet = rte_zmalloc_socket(NULL,
> - packet_size, 0, internals->numa_node);
> + packet_size, 0, dev->data->numa_node);
> if (dummy_packet == NULL)
> return -ENOMEM;
>
> @@ -271,7 +262,7 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
>
> internals = dev->data->dev_private;
>
> - if (tx_queue_id >= internals->nb_tx_queues)
> + if (tx_queue_id >= dev->data->nb_tx_queues)
> return -ENODEV;
>
> packet_size = internals->packet_size;
> @@ -279,7 +270,7 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
> dev->data->tx_queues[tx_queue_id] =
> &internals->tx_null_queues[tx_queue_id];
> dummy_packet = rte_zmalloc_socket(NULL,
> - packet_size, 0, internals->numa_node);
> + packet_size, 0, dev->data->numa_node);
> if (dummy_packet == NULL)
> return -ENOMEM;
>
> @@ -323,7 +314,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
>
> internal = dev->data->dev_private;
> num_stats = RTE_MIN((unsigned)RTE_ETHDEV_QUEUE_STAT_CNTRS,
> - RTE_MIN(internal->nb_rx_queues,
> + RTE_MIN(dev->data->nb_rx_queues,
> RTE_DIM(internal->rx_null_queues)));
> for (i = 0; i < num_stats; i++) {
> igb_stats->q_ipackets[i] =
> @@ -332,7 +323,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
> }
>
> num_stats = RTE_MIN((unsigned)RTE_ETHDEV_QUEUE_STAT_CNTRS,
> - RTE_MIN(internal->nb_tx_queues,
> + RTE_MIN(dev->data->nb_tx_queues,
> RTE_DIM(internal->tx_null_queues)));
> for (i = 0; i < num_stats; i++) {
> igb_stats->q_opackets[i] =
> @@ -535,11 +526,8 @@ eth_dev_null_create(const char *name,
> /* NOTE: we'll replace the data element, of originally allocated eth_dev
> * so the nulls are local per-process */
>
> - internals->nb_rx_queues = nb_rx_queues;
> - internals->nb_tx_queues = nb_tx_queues;
> internals->packet_size = packet_size;
> internals->packet_copy = packet_copy;
> - internals->numa_node = numa_node;
>
> internals->flow_type_rss_offloads = ETH_RSS_PROTO_MASK;
> internals->reta_size = RTE_DIM(internals->reta_conf) * RTE_RETA_GROUP_SIZE;
> @@ -560,10 +548,10 @@ eth_dev_null_create(const char *name,
> TAILQ_INIT(ð_dev->link_intr_cbs);
>
> eth_dev->driver = NULL;
> - eth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;
> - eth_dev->data->kdrv = RTE_KDRV_NONE;
> - eth_dev->data->drv_name = drivername;
> - eth_dev->data->numa_node = numa_node;
> + data->dev_flags = RTE_ETH_DEV_DETACHABLE;
> + data->kdrv = RTE_KDRV_NONE;
> + data->drv_name = drivername;
> + data->numa_node = numa_node;
>
> /* finally assign rx and tx ops */
> if (packet_copy) {
Tested-by: Tetsuya Mukawa <mukawa@igel.co.jp>
Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>
next prev parent reply other threads:[~2016-02-03 6:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 17:16 [dpdk-dev] [PATCH 0/3] clean-up on virtual PMDs Ferruh Yigit
2016-01-29 17:16 ` [dpdk-dev] [PATCH 1/3] pcap: remove duplicate fields in internal data struct Ferruh Yigit
2016-01-29 17:16 ` [dpdk-dev] [PATCH 2/3] ring: " Ferruh Yigit
2016-02-17 17:36 ` Bruce Richardson
2016-02-18 9:50 ` Ferruh Yigit
2016-01-29 17:16 ` [dpdk-dev] [PATCH 3/3] null: " Ferruh Yigit
2016-02-03 6:21 ` Tetsuya Mukawa [this message]
2016-02-18 11:26 ` [dpdk-dev] [PATCH v2 0/3] clean-up on virtual PMDs Ferruh Yigit
2016-02-18 11:26 ` [dpdk-dev] [PATCH v2 1/3] pcap: remove duplicate fields in internal data struct Ferruh Yigit
2016-02-22 9:54 ` Nicolas Pernas Maradei
2016-02-18 11:26 ` [dpdk-dev] [PATCH v2 2/3] ring: " Ferruh Yigit
2016-02-22 9:55 ` Nicolas Pernas Maradei
2016-02-23 15:26 ` Bruce Richardson
2016-02-23 15:58 ` Ferruh Yigit
2016-02-23 16:06 ` Bruce Richardson
2016-02-18 11:26 ` [dpdk-dev] [PATCH v2 3/3] null: " Ferruh Yigit
2016-02-22 9:56 ` Nicolas Pernas Maradei
2016-02-26 15:26 ` [dpdk-dev] [PATCH v3 0/3] clean-up on virtual PMDs Ferruh Yigit
2016-02-26 15:26 ` [dpdk-dev] [PATCH v3 1/3] pcap: remove duplicate fields in internal data struct Ferruh Yigit
2016-02-26 15:26 ` [dpdk-dev] [PATCH v3 2/3] ring: rename " Ferruh Yigit
2016-02-26 16:35 ` Bruce Richardson
2016-02-26 15:26 ` [dpdk-dev] [PATCH v3 3/3] null: remove duplicate " Ferruh Yigit
2016-02-26 16:58 ` [dpdk-dev] [PATCH v4 0/3] clean-up on virtual PMDs Ferruh Yigit
2016-02-26 16:58 ` [dpdk-dev] [PATCH v4 1/3] pcap: remove duplicate fields in internal data struct Ferruh Yigit
2016-02-26 16:58 ` [dpdk-dev] [PATCH v4 2/3] ring: variable rename and code cleanup Ferruh Yigit
2016-03-10 11:11 ` Bruce Richardson
2016-02-26 16:58 ` [dpdk-dev] [PATCH v4 3/3] null: remove duplicate fields in internal data struct Ferruh Yigit
2016-03-10 11:12 ` [dpdk-dev] [PATCH v4 0/3] clean-up on virtual PMDs Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B19C5C.20800@igel.co.jp \
--to=mukawa@igel.co.jp \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nicolas.pernas.maradei@emutex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).