From: Didier Pallard <didier.pallard@6wind.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] hash: fix CRC32c computation
Date: Thu, 11 Feb 2016 09:21:21 +0100 [thread overview]
Message-ID: <56BC4481.1060009@6wind.com> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831FFC2238@IRSMSX109.ger.corp.intel.com>
Ok, i will fix the typo and propose a second serie of patch including
unit tests.
thanks
On 02/10/2016 03:35 PM, Pattan, Reshma wrote:
> Hi,
>
> Small typo.
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Didier Pallard
>> Sent: Tuesday, December 22, 2015 9:35 AM
>> To: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; De Lara
>> Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> Subject: [dpdk-dev] [PATCH] hash: fix CRC32c computation
>> diff --git a/lib/librte_hash/rte_hash_crc.h b/lib/librte_hash/rte_hash_crc.h index
>> 78a34b7..485f8a2 100644
>> --- a/lib/librte_hash/rte_hash_crc.h
>> +++ b/lib/librte_hash/rte_hash_crc.h
>> + * Use single crc32 instruction to perform a hash on a byte value.
> "on a byte value" should be ===> "on 2 bytes".
>
>> + * Fall back to software crc32 implementation in case SSE4.2 is
>> + * not supported
>> + *
>> + * @param data
>> + * Data to perform hash on.
>> + * @param init_val
>> + * Value to initialise hash generator.
>> + * @return
>> + * 32bit calculated hash value.
>> + */
>> +static inline uint32_t
>> +rte_hash_crc_2byte(uint16_t data, uint32_t init_val) { #if defined
>> +RTE_ARCH_I686 || defined RTE_ARCH_X86_64
>> + if (likely(crc32_alg & CRC32_SSE42))
>> + return crc32c_sse42_u16(data, init_val); #endif
>> +
>> + return crc32c_2bytes(data, init_val);
>> +}
>> +
> Thanks,
> Reshma
--
Didier PALLARD
6WIND
Software Engineer
Tel: +33 1 39 30 92 46
Mob: +33 6 49 11 40 14
Fax: +33 1 39 30 92 11
didier.pallard@6wind.com
www.6wind.com
This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to 6WIND. All unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.
Ce courriel ainsi que toutes les pièces jointes, est uniquement destiné à son ou ses destinataires. Il contient des informations confidentielles qui sont la propriété de 6WIND. Toute révélation, distribution ou copie des informations qu'il contient est strictement interdite. Si vous avez reçu ce message par erreur, veuillez immédiatement le signaler à l'émetteur et détruire toutes les données reçues
prev parent reply other threads:[~2016-02-11 8:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 9:34 Didier Pallard
2015-12-23 9:12 ` Qiu, Michael
2015-12-23 11:37 ` Vincent JARDIN
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8973C8A16BD@IRSMSX108.ger.corp.intel.com>
2016-02-08 14:43 ` De Lara Guarch, Pablo
2016-02-09 9:34 ` [dpdk-dev] [PATCH v2] " Didier Pallard
2016-02-10 12:16 ` De Lara Guarch, Pablo
2016-02-19 11:00 ` [dpdk-dev] [PATCH v3 0/2] Fix " Didier Pallard
2016-02-19 11:00 ` [dpdk-dev] [PATCH v3 1/2] test: fix CRC hash function autotest Didier Pallard
2016-02-19 11:00 ` [dpdk-dev] [PATCH v3 2/2] hash: fix CRC32c computation Didier Pallard
2016-02-19 15:08 ` [dpdk-dev] [PATCH v3 0/2] Fix " De Lara Guarch, Pablo
2016-03-01 13:31 ` Thomas Monjalon
2016-02-10 14:35 ` [dpdk-dev] [PATCH] hash: fix " Pattan, Reshma
2016-02-11 8:21 ` Didier Pallard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BC4481.1060009@6wind.com \
--to=didier.pallard@6wind.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).