From: Panu Matilainen <pmatilai@redhat.com>
To: Jasvinder Singh <jasvinder.singh@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 1/2] librte_pipeline: add support for packet redirection at action handlers
Date: Thu, 3 Mar 2016 11:35:05 +0200 [thread overview]
Message-ID: <56D80549.7070200@redhat.com> (raw)
In-Reply-To: <1456951307-35264-1-git-send-email-jasvinder.singh@intel.com>
On 03/02/2016 10:41 PM, Jasvinder Singh wrote:
> Currently, there is no mechanism that allows the pipeline ports (in/out) and
> table action handlers to override the default forwarding decision (as
> previously configured per input port or in the table entry). Therefore, new
> pipeline API functions have been added which allows action handlers to
> hijack packets and remove them from the pipeline processing, and then either
> drop them or send them out of the pipeline on any output port. The port
> (in/out) and table action handler prototypes have been changed for making
> use of these new API functions. This feature will be helpful to implement
> functions such as exception handling (e.g. TTL =0), load balancing etc.
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
> v3
> * improved comments in "rte_pipeline.h"
>
> v2
> * rebased on master
>
> doc/guides/rel_notes/deprecation.rst | 5 -
> doc/guides/rel_notes/release_16_04.rst | 6 +-
> lib/librte_pipeline/Makefile | 4 +-
> lib/librte_pipeline/rte_pipeline.c | 461 ++++++++++++++-------------
> lib/librte_pipeline/rte_pipeline.h | 174 ++++++----
> lib/librte_pipeline/rte_pipeline_version.map | 8 +
> 6 files changed, 362 insertions(+), 296 deletions(-)
>
[...]
This causes a build failure:
== Build app/test-pipeline
CC pipeline_stub.o
/srv/work/repos/dpdk/app/test-pipeline/pipeline_stub.c: In function
‘app_main_loop_worker_pipeline_stub’:
/srv/work/repos/dpdk/app/test-pipeline/pipeline_stub.c:97:4: error:
unknown field ‘f_action_bulk’ specified in initializer
.f_action_bulk = NULL,
^
/srv/work/repos/dpdk/mk/internal/rte.compile-pre.mk:126: recipe for
target 'pipeline_stub.o' failed
Each individual commit needs to be buildable. Since its simply an
incompatible API change, I guess there's no other way than updating the
test app(s) in the same commit as the library. The other alternative
would be temporarily disabling the test app(s) in the previous commit
but that doesn't seem any better to me.
- Panu -
next prev parent reply other threads:[~2016-03-03 9:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 14:11 [dpdk-dev] [PATCH " Jasvinder Singh
2016-01-25 14:11 ` [dpdk-dev] [PATCH 2/2] modify action handlers in test_pipeline and ip_pipeline Jasvinder Singh
2016-02-29 14:50 ` [dpdk-dev] [PATCH v2 1/2] librte_pipeline: add support for packet redirection at action handlers Jasvinder Singh
2016-02-29 14:50 ` [dpdk-dev] [PATCH v2 2/2] modify action handlers in test_pipeline and ip_pipeline Jasvinder Singh
2016-03-02 20:41 ` [dpdk-dev] [PATCH v3 1/2] librte_pipeline: add support for packet redirection at action handlers Jasvinder Singh
2016-03-02 20:41 ` [dpdk-dev] [PATCH v3 2/2] modify action handlers in test_pipeline and ip_pipeline Jasvinder Singh
2016-03-03 9:35 ` Panu Matilainen [this message]
2016-03-03 9:58 ` [dpdk-dev] [PATCH v3 1/2] librte_pipeline: add support for packet redirection at action handlers Singh, Jasvinder
2016-03-03 11:01 ` [dpdk-dev] [PATCH v4] " Jasvinder Singh
2016-03-07 11:01 ` Thomas Monjalon
2016-03-07 11:29 ` Singh, Jasvinder
2016-03-07 11:38 ` Thomas Monjalon
2016-03-08 18:07 ` [dpdk-dev] [PATCH v5 1/2] " Jasvinder Singh
2016-03-08 18:07 ` [dpdk-dev] [PATCH v5 2/2] librte_pipeline: add new API functions for pipeline " Jasvinder Singh
2016-03-10 0:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D80549.7070200@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).