From: Panu Matilainen <pmatilai@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] mk: stop on warning only in developer build
Date: Thu, 3 Mar 2016 12:53:17 +0200 [thread overview]
Message-ID: <56D8179D.8070905@redhat.com> (raw)
In-Reply-To: <3110515.Sqe0BZWodk@xps13>
On 03/03/2016 12:36 PM, Thomas Monjalon wrote:
> 2016-03-02 22:04, Bruce Richardson:
>> On Wed, Mar 02, 2016 at 03:22:23PM +0100, Thomas Monjalon wrote:
>>> From: Panu Matilainen <pmatilai@redhat.com>
>>>
>>> Add RTE_DEVEL_BUILD make-variable which can be used to do things
>>> differently when doing development vs building a release,
>>> autodetected from source root .git presence and overridable via
>>> commandline. It is used it to enable -Werror compiler flag and may
>>> be extended to other checks.
>>>
>>> Failing build on warnings is a useful developer tool but its bad
>>> for release tarballs which can and do get built with newer
>>> compilers than what was used/available during development. Compilers
>>> routinely add new warnings so code which built silently with cc X
>>> might no longer do so with X+1. This doesn't make the existing code
>>> any more buggier and failing the build in this case does not help
>>> to improve the quality of an already released version either.
>>>
>>> This change the default flags which can be tuned with EXTRA_CFLAGS.
>>>
>>> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>>> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>>
>> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Applied, thanks
Thanks for dusting this up, I'd pretty much forgotten the whole thing.
- Panu -
next prev parent reply other threads:[~2016-03-03 10:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 11:13 [dpdk-dev] [PATCH] Make -Werror optional Panu Matilainen
2015-02-12 11:25 ` Bruce Richardson
2015-02-12 12:02 ` Panu Matilainen
2015-02-12 12:08 ` Bruce Richardson
2015-02-12 13:58 ` Panu Matilainen
2015-02-12 14:02 ` Bruce Richardson
2015-02-12 14:05 ` Thomas Monjalon
2015-02-12 15:18 ` [dpdk-dev] [PATCH v2] mk: Only default to -Werror when building from git checkout Panu Matilainen
2015-02-20 12:15 ` Thomas Monjalon
2015-02-21 2:15 ` Stephen Hemminger
2015-02-21 10:48 ` Thomas Monjalon
2016-03-02 14:22 ` [dpdk-dev] [PATCH v3] mk: stop on warning only in developer build Thomas Monjalon
2016-03-02 22:04 ` Bruce Richardson
2016-03-03 10:36 ` Thomas Monjalon
2016-03-03 10:53 ` Panu Matilainen [this message]
2015-02-12 14:38 ` [dpdk-dev] [PATCH] Make -Werror optional Stephen Hemminger
2015-02-12 14:54 ` Panu Matilainen
2015-02-21 1:55 ` Stephen Hemminger
2015-02-21 19:33 ` Neil Horman
2015-02-23 8:19 ` Panu Matilainen
2015-02-23 13:55 ` Neil Horman
2015-02-23 14:20 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D8179D.8070905@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).