From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bernard Iremonger <bernard.iremonger@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bonding: fix crash when no slave devices
Date: Fri, 4 Mar 2016 17:13:31 +0000 [thread overview]
Message-ID: <56D9C23B.8000508@intel.com> (raw)
In-Reply-To: <1456229580-25009-1-git-send-email-bernard.iremonger@intel.com>
On 2/23/2016 12:13 PM, Bernard Iremonger wrote:
> If a bonded device is created when there are no slave devices
> there is loop in bond_ethdev_promiscous_enable() which results
> in a segmentation fault.
> I have applied a similar fix to bond_ethdev_promiscous_disable()
> where a similar loop could occur.
>
> Fixes: 2efb58cbab6e ("bond: new link bonding library")
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index b63c886..78972fc 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -1870,7 +1870,8 @@ bond_ethdev_promiscuous_enable(struct rte_eth_dev *eth_dev)
> case BONDING_MODE_TLB:
> case BONDING_MODE_ALB:
> default:
> - rte_eth_promiscuous_enable(internals->current_primary_port);
> + if (internals->slave_count > 0)
> + rte_eth_promiscuous_enable(internals->current_primary_port);
> }
> }
>
> @@ -1898,7 +1899,8 @@ bond_ethdev_promiscuous_disable(struct rte_eth_dev *dev)
> case BONDING_MODE_TLB:
> case BONDING_MODE_ALB:
> default:
> - rte_eth_promiscuous_disable(internals->current_primary_port);
> + if (internals->slave_count > 0)
> + rte_eth_promiscuous_disable(internals->current_primary_port);
> }
> }
>
>
Hi Bernard,
The reason of this crash is when there is no slave, the value of
current_primary_port is 0, which is valid port_id, is this correct?
Does it make sense, instead of slave_count check, to make default
current_primary_port value a non valid port_id, like -1, so
is_valid_port() check catches it to prevents crash? For this and any
other cases.
Thanks,
ferruh
next prev parent reply other threads:[~2016-03-04 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 12:13 Bernard Iremonger
2016-03-04 17:13 ` Ferruh Yigit [this message]
2016-03-04 17:20 ` Iremonger, Bernard
2016-03-07 11:40 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2016-03-07 12:14 ` Ferruh Yigit
2016-03-11 16:40 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D9C23B.8000508@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).