From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/3] ethdev: add helper functions to get eth_dev and dev private data
Date: Thu, 10 Mar 2016 13:37:51 +0000 [thread overview]
Message-ID: <56E178AF.9000207@intel.com> (raw)
In-Reply-To: <2720050.b5GnNWtRZF@xps13>
On 3/10/2016 12:00 AM, Thomas Monjalon wrote:
> 2016-02-17 14:20, Ferruh Yigit:
>> This is to provide abstraction and reduce global variable access.
>>
>> Global variable rte_eth_devices kept exported to not break ABI.
>>
>> Bonding driver not selected on purpose, just it seems it is using
>> rte_eth_devices heavily.
>>
>> There are a few more usage in drivers but they left as it is because they
>> are in fast path code.
>
> What is the benefit of these functions if you do not plan to remove the
> global variables later?
>
- Better discipline to abstract, function call can be costly than direct
access, but I believe this is no problem outside of the fast path.
- Helper functions for common tasks, like get private data by port.
> Anyway this discussion targets the release 16.07.
>
There is no urgency for these.
Thanks,
ferruh
next prev parent reply other threads:[~2016-03-10 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 14:20 Ferruh Yigit
2016-02-17 14:20 ` [dpdk-dev] [PATCH 1/3] " Ferruh Yigit
2016-02-17 14:20 ` [dpdk-dev] [PATCH 2/3] app/test: use ethdev helper functions Ferruh Yigit
2016-02-17 14:20 ` [dpdk-dev] [PATCH 3/3] bonding: " Ferruh Yigit
2016-03-10 0:00 ` [dpdk-dev] [PATCH 0/3] ethdev: add helper functions to get eth_dev and dev private data Thomas Monjalon
2016-03-10 13:37 ` Ferruh Yigit [this message]
2016-06-22 21:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E178AF.9000207@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).