From: "Hunt, David" <david.hunt@intel.com>
To: Jan Medala <jan@semihalf.com>, dev@dpdk.org
Cc: Evgeny Schemeilin <evgenys@amazon.com>, matua@amazon.com
Subject: Re: [dpdk-dev] [PATCH v5 4/4] ena: DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA)
Date: Thu, 10 Mar 2016 15:22:04 +0000 [thread overview]
Message-ID: <56E1911C.3080803@intel.com> (raw)
In-Reply-To: <1457381110-20382-5-git-send-email-jan@semihalf.com>
Hi Jan,
On 3/7/2016 8:05 PM, Jan Medala wrote:
--snip--
> diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h
> new file mode 100644
> index 0000000..7f069b9
> --- /dev/null
> +++ b/drivers/net/ena/ena_ethdev.h
> @@ -0,0 +1,154 @@
> +/*-
> +* BSD LICENSE
> +*
> +* Copyright (c) 2015-2016 Amazon.com, Inc. or its affiliates.
> +* All rights reserved.
> +*
> +* Redistribution and use in source and binary forms, with or without
> +* modification, are permitted provided that the following conditions
> +* are met:
> +*
> +* * Redistributions of source code must retain the above copyright
> +* notice, this list of conditions and the following disclaimer.
> +* * Redistributions in binary form must reproduce the above copyright
> +* notice, this list of conditions and the following disclaimer in
> +* the documentation and/or other materials provided with the
> +* distribution.
> +* * Neither the name of copyright holder nor the names of its
> +* contributors may be used to endorse or promote products derived
> +* from this software without specific prior written permission.
> +*
> +* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +*/
> +
> +#ifndef _ENA_ETHDEV_H_
> +#define _ENA_ETHDEV_H_
> +
> +#include <rte_pci.h>
> +
> +#pragma GCC diagnostic ignored "-Wcast-qual"
Is this #pragma really needed here? My setup compiles fine without
warnings, and I reckon it's better not have this line if it's not needed
just in case we inadvertently introduce additional warnings in the future.
---snip--
The only other thing I'd note with the rest of the patch-set is the
output from checkpatch, which Bruce has already mentioned.
Regards,
David.
next prev parent reply other threads:[~2016-03-10 15:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 20:05 [dpdk-dev] [PATCH v5 0/4] " Jan Medala
2016-03-07 20:05 ` [dpdk-dev] [PATCH v5 1/4] ena: Amazon ENA documentation Jan Medala
2016-03-09 12:39 ` Thomas Monjalon
2016-03-10 14:47 ` Hunt, David
2016-03-07 20:05 ` [dpdk-dev] [PATCH v5 2/4] ena: Amazon ENA communication laye Jan Medala
2016-03-09 12:55 ` Thomas Monjalon
2016-03-07 20:05 ` [dpdk-dev] [PATCH v5 3/4] ena: Amazon ENA communication layer for DPDK platform Jan Medala
2016-03-07 20:05 ` [dpdk-dev] [PATCH v5 4/4] ena: DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA) Jan Medala
2016-03-10 15:22 ` Hunt, David [this message]
2016-03-09 11:34 ` [dpdk-dev] [PATCH v5 0/4] " Jan Mędala
2016-03-10 12:00 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E1911C.3080803@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=jan@semihalf.com \
--cc=matua@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).