From: Panu Matilainen <pmatilai@redhat.com>
To: Helin Zhang <helin.zhang@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add vlan type for setting ether type
Date: Fri, 11 Mar 2016 13:19:17 +0200 [thread overview]
Message-ID: <56E2A9B5.60605@redhat.com> (raw)
In-Reply-To: <1457686179-20435-2-git-send-email-helin.zhang@intel.com>
On 03/11/2016 10:49 AM, Helin Zhang wrote:
> In order to set ether type of VLAN for single VLAN, inner
> and outer VLAN, the VLAN type as an input parameter is added
> to 'rte_eth_dev_set_vlan_ether_type()'.
> In addition, corresponding changes in e1000, ixgbe and i40e
> are also added.
>
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
> app/test-pmd/cmdline.c | 30 +++++++++-----
> app/test-pmd/config.c | 9 +++--
> app/test-pmd/testpmd.h | 3 +-
> doc/guides/rel_notes/release_16_04.rst | 4 ++
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 +----
> drivers/net/e1000/igb_ethdev.c | 21 +++++++---
> drivers/net/i40e/i40e_ethdev.c | 63 +++++++++++++++++++++++++++--
> drivers/net/ixgbe/ixgbe_ethdev.c | 19 +++++++--
> lib/librte_ether/rte_ethdev.c | 25 +++++++++++-
> lib/librte_ether/rte_ethdev.h | 23 ++++++++++-
> lib/librte_ether/rte_ether_version.map | 7 ++++
> 11 files changed, 175 insertions(+), 40 deletions(-)
>
> v4:
> - Updated the doc of testpmd guide.
>
> v3:
> - Used versioning mechanism to avoid ABI issue.
> - Re-organized the patch set.
>
> v2:
> - Used RTE_NEXT_ABI to avoid ABI change issue.
> - Reworked the announcement of ABI change for release 16.07.
>
[...]
> @@ -1077,7 +1088,7 @@ typedef int (*vlan_filter_set_t)(struct rte_eth_dev *dev,
> /**< @internal filtering of a VLAN Tag Identifier by an Ethernet device. */
>
> typedef void (*vlan_tpid_set_t)(struct rte_eth_dev *dev,
> - uint16_t tpid);
> + enum rte_vlan_type type, uint16_t tpid);
> /**< @internal set the outer VLAN-TPID by an Ethernet device. */
>
> typedef void (*vlan_offload_set_t)(struct rte_eth_dev *dev, int mask);
> @@ -2346,6 +2357,8 @@ int rte_eth_dev_set_vlan_strip_on_queue(uint8_t port_id, uint16_t rx_queue_id,
> *
> * @param port_id
> * The port identifier of the Ethernet device.
> + * @vlan_type
> + * The vlan type.
> * @param tag_type
> * The Tag Protocol ID
> * @return
> @@ -2353,7 +2366,13 @@ int rte_eth_dev_set_vlan_strip_on_queue(uint8_t port_id, uint16_t rx_queue_id,
> * - (-ENOSUP) if hardware-assisted VLAN TPID setup is not supported.
> * - (-ENODEV) if *port_id* invalid.
> */
> -int rte_eth_dev_set_vlan_ether_type(uint8_t port_id, uint16_t tag_type);
> +int rte_eth_dev_set_vlan_ether_type(uint8_t port_id,
> + enum rte_vlan_type vlan_type,
> + uint16_t tag_type);
> +int rte_eth_dev_set_vlan_ether_type_v22(uint8_t port_id, uint16_t tag_type);
> +int rte_eth_dev_set_vlan_ether_type_v1604(uint8_t port_id,
> + enum rte_vlan_type vlan_type,
> + uint16_t tag_type);
>
> /**
> * Set VLAN offload configuration on an Ethernet device
Its nice to see people actually trying to be compatible on occasion :)
However in this case there's not much point in doing so, because
libethdev ABI has already been broken in this cycle:
http://dpdk.org/browse/dpdk/commit/?id=cfd2279ea6299826fe992028f1dffaf9fa7e7d0a
In other words, the compatibility versions can never get invoked because
all software built against libethdev needs to be rebuilt anyway because
of the soname bump. Just drop the compat versions, no point carrying
around something that cannot possibly get used.
- Panu -
next prev parent reply other threads:[~2016-03-11 11:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 1:37 [dpdk-dev] [PATCH 0/2] i40e setting ether type of VLANs Helin Zhang
2016-01-22 1:37 ` [dpdk-dev] [PATCH 1/2] ethdev: add vlan type for setting ether type Helin Zhang
2016-01-22 1:37 ` [dpdk-dev] [PATCH 2/2] i40e: add VLAN ether type config Helin Zhang
2016-03-07 8:12 ` [dpdk-dev] [PATCH v2 0/3] i40e setting ether type of VLANs Helin Zhang
2016-03-07 8:12 ` [dpdk-dev] [PATCH v2 1/3] ethdev: add vlan type for setting ether type Helin Zhang
2016-03-07 8:12 ` [dpdk-dev] [PATCH v2 2/3] i40e: add VLAN ether type config Helin Zhang
2016-03-07 8:12 ` [dpdk-dev] [PATCH v2 3/3] i40e: fix the overflow issue Helin Zhang
2016-03-07 9:28 ` [dpdk-dev] [PATCH v2 0/3] i40e setting ether type of VLANs Thomas Monjalon
2016-03-09 15:20 ` Zhang, Helin
2016-03-10 16:36 ` [dpdk-dev] [PATCH v3 0/2] " Helin Zhang
2016-03-10 16:36 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add vlan type for setting ether type Helin Zhang
2016-03-10 16:36 ` [dpdk-dev] [PATCH v3 2/2] i40e: fix the overflow issue Helin Zhang
2016-03-11 2:36 ` [dpdk-dev] [PATCH v3 0/2] i40e setting ether type of VLANs Lu, Wenzhuo
2016-03-11 8:49 ` [dpdk-dev] [PATCH v4 " Helin Zhang
2016-03-11 8:49 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add vlan type for setting ether type Helin Zhang
2016-03-11 11:19 ` Panu Matilainen [this message]
2016-03-11 11:20 ` Thomas Monjalon
2016-03-11 14:17 ` Zhang, Helin
2016-03-11 14:20 ` Thomas Monjalon
2016-03-11 8:49 ` [dpdk-dev] [PATCH v4 2/2] i40e: fix the overflow issue Helin Zhang
2016-03-11 16:50 ` [dpdk-dev] [PATCH v5 0/2] i40e setting ether type of VLANs Helin Zhang
2016-03-11 16:50 ` [dpdk-dev] [PATCH v5 1/2] ethdev: add vlan type for setting ether type Helin Zhang
2016-03-11 16:50 ` [dpdk-dev] [PATCH v5 2/2] i40e: fix the overflow issue Helin Zhang
2016-03-11 20:20 ` [dpdk-dev] [PATCH v5 0/2] i40e setting ether type of VLANs Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E2A9B5.60605@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).