From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: Fix Missed Headers For FreeBSD
Date: Thu, 31 Mar 2016 12:22:13 +0100 [thread overview]
Message-ID: <56FD0865.8090103@intel.com> (raw)
In-Reply-To: <1459415578-3692-1-git-send-email-danielx.t.mrzyglod@intel.com>
Commit title shouldn't contain capital letters.
On 31/03/2016 10:12, Daniel Mrzyglod wrote:
> There were misssed typedef for u_char - <sys/types.h>
> There were missed network definitions - <netinet/in.h>
Something a bit more descriptive along the lines of:
In FreeBSD, sys/types.h and netinet/in.h need to be included before
netinet/ip.h.
> Failure #13: http://dpdk.org/ml/archives/test-report/2016-March/001896.html
>
> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
> examples/ipsec-secgw/esp.c | 4 +++-
> examples/ipsec-secgw/ipsec.c | 2 +-
> examples/ipsec-secgw/rt.c | 1 +
> examples/ipsec-secgw/sa.c | 2 ++
> examples/ipsec-secgw/sp.c | 2 ++
> 5 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c
> index ca0fc56..7b0e04c 100644
> --- a/examples/ipsec-secgw/esp.c
> +++ b/examples/ipsec-secgw/esp.c
> @@ -33,8 +33,10 @@
>
> #include <stdint.h>
> #include <stdlib.h>
> -#include <netinet/ip.h>
> #include <sys/types.h>
> +#include <sys/socket.h>
Do we need sys/socket.h?
Sergio
next prev parent reply other threads:[~2016-03-31 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 9:12 Daniel Mrzyglod
2016-03-31 11:22 ` Sergio Gonzalez Monroy [this message]
2016-03-31 12:43 ` [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix missed headers for FreeBSD Daniel Mrzyglod
2016-03-31 13:02 ` Sergio Gonzalez Monroy
2016-03-31 20:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD0865.8090103@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).