From: Nelson Escobar <neescoba@cisco.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"John Daley (johndale)" <johndale@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] bonding: fix bond link detect in non-interrupt mode
Date: Thu, 31 Mar 2016 10:33:21 -0700 [thread overview]
Message-ID: <56FD5F61.9010002@cisco.com> (raw)
In-Reply-To: <5397245.3TK0dfaEoQ@xps13>
Thomas,
Sorry, I should have included the following fixes line:
Fixes: a45b288ef21a("bond: support link status polling")
Please add it to the commit message when applying if there are no other
problems with the patch.
Nelson.
On 3/31/2016 6:40 AM, Thomas Monjalon wrote:
> 2016-03-25 17:44, John Daley:
>> From: Nelson Escobar <neescoba@cisco.com>
>>
>> Stopping then re-starting a bond interface containing slaves that
>> used polling for link detection caused the bond to think all slave
>> links were down and inactive.
>>
>> Move the start of the polling for link from slave_add() to
>> bond_ethdev_start() and in bond_ethdev_stop() make sure we clear
>> the last_link_status of the slaves.
>>
>> Signed-off-by: Nelson Escobar <neescoba@cisco.com>
>> Signed-off-by: John Daley <johndale@cisco.com>
>
> A "Fixes:" line would be appreciated to know the origin of the bug.
> Thanks
>
next prev parent reply other threads:[~2016-03-31 17:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-26 0:44 John Daley
2016-03-30 16:15 ` Thomas Monjalon
2016-03-31 13:40 ` Thomas Monjalon
2016-03-31 17:33 ` Nelson Escobar [this message]
2016-04-01 13:35 ` Declan Doherty
2016-04-01 8:00 Doherty, Declan
2016-04-01 13:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD5F61.9010002@cisco.com \
--to=neescoba@cisco.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).