From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Luca Boccassi <bluca@debian.org>,
Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org
Cc: ophirmu@mellanox.com, mk@semihalf.com
Subject: Re: [dpdk-dev] [PATCH] drivers/net: set close behaviour flag at probing
Date: Mon, 12 Nov 2018 15:28:31 +0000 [thread overview]
Message-ID: <56eaee8e-702d-0d9d-7cb8-b1a7533d501c@intel.com> (raw)
In-Reply-To: <1542015769.11515.0.camel@debian.org>
On 11/12/2018 9:42 AM, Luca Boccassi wrote:
> On Sun, 2018-11-11 at 23:46 +0100, Thomas Monjalon wrote:
>> The ethdev flag RTE_ETH_DEV_CLOSE_REMOVE is set for drivers
>> having migrated to the new behaviour of rte_eth_dev_close().
>>
>> As any other flag, it can be useful to know about its value
>> as soon as the port is probed.
>> Unfortunately, it was set inside the close operation,
>> just before being erased by memset() in rte_eth_dev_release_port().
>> The flag assignment is moved to the probing stage, so it can
>> be checked by the application in order to anticipate the behaviour.
>>
>> Fixes: 42603bbdb58e ("net/mlx5: release port on close")
>> Cc: ophirmu@mellanox.com
>> Fixes: 6c99085d972b ("net/vmxnet3: fix hot-unplug")
>> Cc: bluca@debian.org
>> Fixes: 4d7877fde2ef ("net/ena: remove resources when port is being
>> closed")
>> Cc: mk@semihalf.com
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>> drivers/net/ena/ena_ethdev.c | 11 ++++++-----
>> drivers/net/mlx5/mlx5.c | 7 ++-----
>> drivers/net/vmxnet3/vmxnet3_ethdev.c | 9 +++------
>> 3 files changed, 11 insertions(+), 16 deletions(-)
>
> Acked-by: Luca Boccassi <bluca@debian.org>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-11-12 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 22:46 Thomas Monjalon
2018-11-12 9:42 ` Luca Boccassi
2018-11-12 15:28 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56eaee8e-702d-0d9d-7cb8-b1a7533d501c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=mk@semihalf.com \
--cc=ophirmu@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).