From: Olivier MATZ <olivier.matz@6wind.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
bruce.richardson@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lpm: fix freeing of rules_tbl in rte_lpm_free_v20
Date: Tue, 12 Apr 2016 17:06:36 +0200 [thread overview]
Message-ID: <570D0EFC.2060107@6wind.com> (raw)
In-Reply-To: <1460468967-9206-1-git-send-email-christian.ehrhardt@canonical.com>
Hi,
On 04/12/2016 03:49 PM, Christian Ehrhardt wrote:
> Back then when we fixed the missing free lpm I was to quickly to say yes
> if it applies not only to the lpm6 but also to all of the lpm code.
>
> It turned out to not apply to all of them. In rte_lpm_create_v20 there
> is an unexpected fused allocation:
> mem_size = sizeof(*lpm) + (sizeof(lpm->rules_tbl[0]) * max_rules);
> [...]
> lpm = (struct rte_lpm_v20 *)rte_zmalloc_socket(mem_name,mem_size,
> RTE_CACHE_LINE_SIZE, socket_id);
>
> That causes lpm->rules_tbl not to have an own struct malloc_elem that
> can be derived via RTE_PTR_SUB(data, MALLOC_ELEM_HEADER_LEN) in
> malloc_elem_from_data.
> Due to that the rte_lpm_free_v20 accidentially misderives the elem and
> assumes it is ELEM_FREE triggering in malloc_elem_free
> if (!malloc_elem_cookies_ok(elem) || elem->state !=
> return -1;
>
> While it seems counter-intuitive the way to properly remove rules_tbl in
> the old fused allocation style of rte_lpm_free_v20 is to not remove it.
>
> The newer rte_lpm_free_v1604 is safe because in rte_lpm_create_v1604
> rules_tbl is a separate allocation.
>
> Fixes: d4c18f0a1d5d ("lpm: fix missing free")
>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thanks, I missed it too during the review.
next prev parent reply other threads:[~2016-04-12 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 13:49 Christian Ehrhardt
2016-04-12 15:06 ` Olivier MATZ [this message]
2016-05-02 10:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570D0EFC.2060107@6wind.com \
--to=olivier.matz@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).