From: Olivier Matz <olivier.matz@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"'John Daley (johndale)'" <johndale@cisco.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] PKT_RX_VLAN_PKT when VLAN stripping is disabled
Date: Mon, 25 Apr 2016 15:50:56 +0200 [thread overview]
Message-ID: <571E20C0.2080509@6wind.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B415A3@irsmsx105.ger.corp.intel.com>
Hi,
On 04/25/2016 02:02 PM, Ananyev, Konstantin wrote:
> Hi John,
> From rte_mbuf.h:
> #define PKT_RX_VLAN_PKT (1ULL << 0) /**< RX packet is a 802.1q VLAN packet. */
> So yes, in theory it should be set up for vlan packet with both stripping on/off.
> The problem is that (as far as I know) when VLAN stripping is disabled FVL RXD doesn't contain information
> does that packet contain a VLAN or not.
> Don't really know what is the best option in that case: keep things as it is or change the meaning of
> the VLAN_PKT flag to indicate is mbuf.vlan_tci field is valid or not.
> Konstantin
It seems the meaning of the PKT_RX_VLAN_PKT bit depends on the port
configuration:
- if vlan stripping is configured, it means VLAN is present in vlan_tci
mbuf field
- if not configured, it means a VLAN is present in the packet
I don't think this is a good behavior since the application has to know
the port configuration to properly interpret the meaning of the flag.
I suggest to change the meaning of this flag to: "vlan was stripped by
hardware, and vlan tag is now located in m->vlan_tci".
The same could apply to PKT_RX_QINQ_PKT and m->outer_vlan_tci.
We could add a new packet_type to tell if the mbuf is a VLAN/QinQ is
detected in the packet but not stripped.
Example:
- vlan stripping is disabled
- vlan packet recvd: flags=0, ptype=RTE_PTYPE_L2_ETHER_VLAN
- qinq packet recvd: flags=0, ptype=RTE_PTYPE_L2_ETHER_QINQ
- vlan stripping is enabled
- vlan packet recvd: flags=PKT_RX_VLAN_PKT, ptype=RTE_PTYPE_L2_ETHER,
m->vlan_tci=id
- qinq packet recvd: flags=PKT_RX_VLAN_PKT|PKT_RX_QINQ_PKT,
ptype=RTE_PTYPE_L2_ETHER, m->vlan_tci=id, m->vlan_tci_outer=id
Thoughts?
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Daley (johndale)
>> Sent: Friday, April 22, 2016 12:37 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] PKT_RX_VLAN_PKT when VLAN stripping is disabled
>>
>> Hi,
>>
>> When VLAN stripping is disabled, X710 and 82599ES act differently for me in this case when receiving VLAN tagged packets. On
>> 82599ES the flag is set but on X710 the flag not set.
>>
>> Do I maybe have old X710 firmware? Or is it not set for X710 on purpose in this case and instead the flag is used to indicate if vlan_tci is
>> valid? Right now the enic pmd does what my X710 does, which I think is incorrect and I want to fix it.
>>
>> Thanks,
>> John
>
next prev parent reply other threads:[~2016-04-25 13:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 23:36 John Daley (johndale)
2016-04-25 12:02 ` Ananyev, Konstantin
2016-04-25 13:50 ` Olivier Matz [this message]
2016-04-25 16:17 ` Ananyev, Konstantin
2016-04-26 0:16 ` John Daley (johndale)
2016-04-28 14:43 ` Olivier MATZ
2016-05-10 16:24 ` [dpdk-dev] [RFC] mbuf: new flag when vlan is stripped Olivier Matz
2016-05-12 20:36 ` John Daley (johndale)
2016-05-23 7:59 ` Olivier Matz
2016-05-23 8:46 ` [dpdk-dev] [PATCH] mbuf: new flag when Vlan " Olivier Matz
2016-05-23 8:59 ` Ananyev, Konstantin
2016-05-23 9:12 ` Olivier Matz
2016-05-23 9:23 ` Ananyev, Konstantin
2016-05-23 9:38 ` Olivier Matz
2016-05-23 9:20 ` Ananyev, Konstantin
2016-05-23 9:40 ` Olivier Matz
2016-05-27 14:33 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2016-06-13 11:41 ` Olivier Matz
2016-06-13 14:42 ` Ananyev, Konstantin
2016-06-13 16:07 ` Olivier Matz
2016-06-13 16:31 ` Ananyev, Konstantin
2016-06-14 8:32 ` Olivier MATZ
2016-06-14 9:15 ` Ananyev, Konstantin
2016-06-14 9:34 ` Olivier MATZ
2016-06-15 11:48 ` [dpdk-dev] [PATCH v3] " Olivier Matz
2016-06-15 12:33 ` Ananyev, Konstantin
2016-06-15 15:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571E20C0.2080509@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).