From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Cc: david.marchand@6wind.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: out-of-bounds write
Date: Tue, 26 Apr 2016 10:44:12 +0100 [thread overview]
Message-ID: <571F386C.3070102@intel.com> (raw)
In-Reply-To: <20160426085343.GA17164@bricha3-MOBL3>
On 26/04/2016 09:53, Bruce Richardson wrote:
> On Tue, Apr 26, 2016 at 09:44:47AM +0200, Slawomir Mrozowicz wrote:
>> Fix issue reported by Coverity.
>>
>> Coverity ID 13282: Out-of-bounds write
>> overrun-local: Overrunning array mcfg->memseg of 256 44-byte elements
>> at element index 257 using index j.
>>
>> Fixes: af75078fece3 ("first public release")
>>
>> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
>> ---
>> lib/librte_eal/linuxapp/eal/eal_memory.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
>> index 5b9132c..1e737e4 100644
>> --- a/lib/librte_eal/linuxapp/eal/eal_memory.c
>> +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
>> @@ -1333,7 +1333,7 @@ rte_eal_hugepage_init(void)
>>
>> if (new_memseg) {
>> j += 1;
>> - if (j == RTE_MAX_MEMSEG)
>> + if (j >= RTE_MAX_MEMSEG)
>> break;
>>
>> mcfg->memseg[j].phys_addr = hugepage[i].physaddr;
>> --
> This does appear to be a valid fix for the issue. However, looking at the code,
> it appears that the only way we could actually hit the problem is if
> j == RTE_MAX_MEMSEG on exiting the previous loop. Would a check there be a better
> fix for this issue (or perhaps we want both fixes).
>
> Thoughts?
It doesn't make sense to go into the loop if we don't have free memsegs.
Either way we should print the error indicating that we reached MAX_MEMSEG.
Sergio
> /Bruce
next prev parent reply other threads:[~2016-04-26 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 7:44 Slawomir Mrozowicz
2016-04-26 8:53 ` Bruce Richardson
2016-04-26 9:44 ` Sergio Gonzalez Monroy [this message]
2016-04-26 11:42 ` Mrozowicz, SlawomirX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571F386C.3070102@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=slawomirx.mrozowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).