From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: add rpath for applications
Date: Tue, 3 May 2016 14:24:22 +0100 [thread overview]
Message-ID: <5728A686.5040004@intel.com> (raw)
In-Reply-To: <2540046.4XauHpbFhJ@xps13>
On 5/2/2016 5:10 PM, Thomas Monjalon wrote:
> 2016-04-29 17:34, Ferruh Yigit:
>> Add default library output folder to the library search folder.
>>
>> This is useful for development environment, in production environment
>> DPDK libraries already should be in know locations.
>
> Yes it is useful in dev environment, but can be risky or strange when
> packaged for production environment.
> Shouldn't we have a switch to avoid a development garbage in production?
> I suggest to use RTE_DEVEL_BUILD.
>
Right, I will use RTE_DEVEL_BUILD
>> Patch removes requirement to set LD_LIBRARY_PATH variable when DPDK
>> compiled as shared library.
>
> Yes, this patch could remove
> export LD_LIBRARY_PATH=$build/lib:$LD_LIBRARY_PATH
> in scripts/test-null.sh.
>
Sure, I can update it.
> [...]
>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
>> +LDFLAGS += --rpath=$(RTE_SDK_BIN)/lib
>> +endif
>
> Isn't it -rpath, with a single dash?
>
It seems both are working, I will convert to single dash.
> As it is a variable setting, it should be added before the rules,
> just after LDLIBS settings.
>
OK.
I will send an updated version.
Thanks for the review,
ferruh
next prev parent reply other threads:[~2016-05-03 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 16:34 Ferruh Yigit
2016-05-02 16:10 ` Thomas Monjalon
2016-05-03 13:24 ` Ferruh Yigit [this message]
2016-05-03 15:03 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-05-18 14:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5728A686.5040004@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).