From: Yongseok Koh <yskoh@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/mlx5: remove unused functions
Date: Thu, 2 May 2019 18:13:14 +0000 [thread overview]
Message-ID: <572DA463-7F7E-4C49-9B16-2858A062CC0E@mellanox.com> (raw)
In-Reply-To: <3a54a27536a425c608c826f79b642f5f203fc3dd.1556809050.git.dekelp@mellanox.com>
> On May 2, 2019, at 8:01 AM, Dekel Peled <dekelp@mellanox.com> wrote:
>
> Functions implemented but never called:
> mlx5_rxq_ibv_releasable()
> mlx5_rxq_cleanup()
> mlx5_txq_ibv_releasable()
>
> Function declared but not implemented:
> rxq_alloc_mprq_buf()
>
> This patch removes these functions from code and header file.
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
> drivers/net/mlx5/mlx5_rxq.c | 31 -------------------------------
> drivers/net/mlx5/mlx5_rxtx.h | 4 ----
> drivers/net/mlx5/mlx5_txq.c | 13 -------------
> 3 files changed, 48 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index 54438a4..db8c340 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -368,24 +368,6 @@
> }
>
> /**
> - * Clean up a RX queue.
> - *
> - * Destroy objects, free allocated memory and reset the structure for reuse.
> - *
> - * @param rxq_ctrl
> - * Pointer to RX queue structure.
> - */
> -void
> -mlx5_rxq_cleanup(struct mlx5_rxq_ctrl *rxq_ctrl)
> -{
> - DRV_LOG(DEBUG, "port %u cleaning up Rx queue %u",
> - PORT_ID(rxq_ctrl->priv), rxq_ctrl->rxq.idx);
> - if (rxq_ctrl->ibv)
> - mlx5_rxq_ibv_release(rxq_ctrl->ibv);
> - memset(rxq_ctrl, 0, sizeof(*rxq_ctrl));
> -}
> -
> -/**
> * Returns the per-queue supported offloads.
> *
> * @param dev
> @@ -1131,19 +1113,6 @@ struct mlx5_rxq_ibv *
> }
>
> /**
> - * Return true if a single reference exists on the object.
> - *
> - * @param rxq_ibv
> - * Verbs Rx queue object.
> - */
> -int
> -mlx5_rxq_ibv_releasable(struct mlx5_rxq_ibv *rxq_ibv)
> -{
> - assert(rxq_ibv);
> - return (rte_atomic32_read(&rxq_ibv->refcnt) == 1);
> -}
> -
> -/**
> * Callback function to initialize mbufs for Multi-Packet RQ.
> */
> static inline void
> diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
> index 0d88375..1732e32 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.h
> +++ b/drivers/net/mlx5/mlx5_rxtx.h
> @@ -251,7 +251,6 @@ struct mlx5_txq_ctrl {
> int mlx5_mprq_enabled(struct rte_eth_dev *dev);
> int mlx5_mprq_free_mp(struct rte_eth_dev *dev);
> int mlx5_mprq_alloc_mp(struct rte_eth_dev *dev);
> -void mlx5_rxq_cleanup(struct mlx5_rxq_ctrl *rxq_ctrl);
> int mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
> unsigned int socket, const struct rte_eth_rxconf *conf,
> struct rte_mempool *mp);
> @@ -263,7 +262,6 @@ int mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
> struct mlx5_rxq_ibv *mlx5_rxq_ibv_new(struct rte_eth_dev *dev, uint16_t idx);
> struct mlx5_rxq_ibv *mlx5_rxq_ibv_get(struct rte_eth_dev *dev, uint16_t idx);
> int mlx5_rxq_ibv_release(struct mlx5_rxq_ibv *rxq_ibv);
> -int mlx5_rxq_ibv_releasable(struct mlx5_rxq_ibv *rxq_ibv);
> struct mlx5_rxq_ibv *mlx5_rxq_ibv_drop_new(struct rte_eth_dev *dev);
> void mlx5_rxq_ibv_drop_release(struct rte_eth_dev *dev);
> int mlx5_rxq_ibv_verify(struct rte_eth_dev *dev);
> @@ -276,7 +274,6 @@ struct mlx5_rxq_ctrl *mlx5_rxq_new(struct rte_eth_dev *dev, uint16_t idx,
> int mlx5_rxq_releasable(struct rte_eth_dev *dev, uint16_t idx);
> int mlx5_rxq_verify(struct rte_eth_dev *dev);
> int rxq_alloc_elts(struct mlx5_rxq_ctrl *rxq_ctrl);
> -int rxq_alloc_mprq_buf(struct mlx5_rxq_ctrl *rxq_ctrl);
> struct mlx5_ind_table_ibv *mlx5_ind_table_ibv_new(struct rte_eth_dev *dev,
> const uint16_t *queues,
> uint32_t queues_n);
> @@ -314,7 +311,6 @@ int mlx5_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
> struct mlx5_txq_ibv *mlx5_txq_ibv_new(struct rte_eth_dev *dev, uint16_t idx);
> struct mlx5_txq_ibv *mlx5_txq_ibv_get(struct rte_eth_dev *dev, uint16_t idx);
> int mlx5_txq_ibv_release(struct mlx5_txq_ibv *txq_ibv);
> -int mlx5_txq_ibv_releasable(struct mlx5_txq_ibv *txq_ibv);
> int mlx5_txq_ibv_verify(struct rte_eth_dev *dev);
> struct mlx5_txq_ctrl *mlx5_txq_new(struct rte_eth_dev *dev, uint16_t idx,
> uint16_t desc, unsigned int socket,
> diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
> index 0b6c247..2cdb1d3 100644
> --- a/drivers/net/mlx5/mlx5_txq.c
> +++ b/drivers/net/mlx5/mlx5_txq.c
> @@ -668,19 +668,6 @@ struct mlx5_txq_ibv *
> }
>
> /**
> - * Return true if a single reference exists on the object.
> - *
> - * @param txq_ibv
> - * Verbs Tx queue object.
> - */
> -int
> -mlx5_txq_ibv_releasable(struct mlx5_txq_ibv *txq_ibv)
> -{
> - assert(txq_ibv);
> - return (rte_atomic32_read(&txq_ibv->refcnt) == 1);
> -}
> -
> -/**
> * Verify the Verbs Tx queue list is empty
> *
> * @param dev
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2019-05-02 18:13 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 11:00 [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 1/4] net/mlx5: remove unused functions Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 2/4] net/mlx5: add missing validation of null pointer Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-04-29 11:00 ` [dpdk-dev] [PATCH 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-04-29 11:00 ` Dekel Peled
2019-05-02 14:10 ` [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files Shahaf Shuler
2019-05-02 14:10 ` Shahaf Shuler
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 " Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 1/4] net/mlx5: remove unused functions Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 18:13 ` Yongseok Koh [this message]
2019-05-02 18:13 ` Yongseok Koh
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 2/4] net/mlx5: fix missing validation of null pointer Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 18:12 ` Yongseok Koh
2019-05-02 18:12 ` Yongseok Koh
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 18:13 ` Yongseok Koh
2019-05-02 18:13 ` Yongseok Koh
2019-05-02 15:01 ` [dpdk-dev] [PATCH v2 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-05-02 15:01 ` Dekel Peled
2019-05-02 18:14 ` Yongseok Koh
2019-05-02 18:14 ` Yongseok Koh
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 1/4] net/mlx5: remove unused functions Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 2/4] net/mlx5: fix missing validation of null pointer Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-05 13:09 ` [dpdk-dev] [PATCH v3 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-05-05 13:09 ` Dekel Peled
2019-05-08 4:43 ` [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files Shahaf Shuler
2019-05-08 4:43 ` Shahaf Shuler
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 " Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 1/4] net/mlx5: remove unused functions Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 2/4] net/mlx5: fix missing validation of null pointer Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 3/4] net/mlx5: fix description of function return value Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-08 8:29 ` [dpdk-dev] [PATCH v4 4/4] net/mlx5: move locally used functions to static Dekel Peled
2019-05-08 8:29 ` Dekel Peled
2019-05-22 20:35 ` [dpdk-dev] [PATCH v4 0/4] net/mlx5: code cleanup in rx and tx files Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572DA463-7F7E-4C49-9B16-2858A062CC0E@mellanox.com \
--to=yskoh@mellanox.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).