From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] sched: fix useless call
Date: Wed, 11 May 2016 10:46:16 +0100 [thread overview]
Message-ID: <5732FF68.50801@intel.com> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126479BAF1D@IRSMSX108.ger.corp.intel.com>
On 5/10/2016 6:18 PM, Dumitrescu, Cristian wrote:
>
>
>> -----Original Message-----
>> From: Mrzyglod, DanielX T
>> Sent: Tuesday, May 10, 2016 11:11 AM
>> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
>> Cc: dev@dpdk.org; Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>
>> Subject: [PATCH] sched: fix useless call
>>
>> Fix issue reported by Coverity.
>> Coverity ID 13338
>>
>> A function call that seems to have an intended effect has no actual effect
>> on the logic of the program.
>>
>> In rte_sched_port_free: A function is called that is only useful for its
>> return value, and this value is ignored.
>>
>> Fixes: de3cfa2c9823 ("sched: initial import")
>>
>> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>> ---
>> lib/librte_sched/rte_sched.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
>> index 1609ea8..9b962a6 100644
>> --- a/lib/librte_sched/rte_sched.c
>> +++ b/lib/librte_sched/rte_sched.c
>> @@ -749,7 +749,6 @@ rte_sched_port_free(struct rte_sched_port *port)
>> rte_pktmbuf_free(mbufs[i]);
>> }
>>
>> - rte_bitmap_free(port->bmp);
>> rte_free(port);
>> }
>>
>> --
>> 2.5.5
>
> NAK.
>
> This needs to be flagged out as a false positive to Coverity.
>
> As previously discussed on this email list, the rte_bitmap_free() is an API function that works as a placeholder for any resource freeing that needs to be done for the bitmap. The API function should not be removed and also the call to this function from the rte_sched_port_free() should not be removed either.
>
Right now it isn't required and doesn't do anything.
Why not add this function when it is required?
Anyway, if we will keep it, I believe it is good to add a comment that
it is a placeholder, to prevent same confusion in the future.
Regards,
ferruh
next prev parent reply other threads:[~2016-05-11 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 10:11 Daniel Mrzyglod
2016-05-10 17:06 ` Ferruh Yigit
2016-05-10 17:18 ` Dumitrescu, Cristian
2016-05-11 9:46 ` Ferruh Yigit [this message]
2016-05-13 10:12 ` Thomas Monjalon
2016-05-13 11:04 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5732FF68.50801@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).