From: Olivier MATZ <olivier.matz@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, david.marchand@6wind.com
Cc: Maxime Leroy <maxime.leroy@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] eal: fix log level/type retrieving on a standard pthread
Date: Thu, 12 May 2016 11:22:13 +0200 [thread overview]
Message-ID: <57344B45.1070702@6wind.com> (raw)
In-Reply-To: <57336031.7060509@intel.com>
Hi Ferruh,
On 05/11/2016 06:39 PM, Ferruh Yigit wrote:
> On 5/9/2016 5:13 PM, Olivier Matz wrote:
>> --- a/lib/librte_eal/common/eal_common_log.c
>> +++ b/lib/librte_eal/common/eal_common_log.c
>> @@ -98,9 +98,10 @@ static int history_enabled = 1;
>> struct log_cur_msg {
>> uint32_t loglevel; /**< log level - see rte_log.h */
>> uint32_t logtype; /**< log type - see rte_log.h */
>> -} __rte_cache_aligned;
>
> Removing alignment seems not related the main purpose of the patch. Is
> this intentional?
Initially, the structure was cache-aligned so each element of
the table was stored in a separate cache line, avoiding a lcore
accessing its element to polute its neighbors (this was by the
way a bit overkill as it's not a performance-sensitive structure).
Using a __thread variable instead of a table naturally removes this
need because it will be stored in a specific section containing only
per-core data.
> I have tested with custom code, non-EAL thread have lcore_id value
> UINT32_MAX, which is > RTE_MAX_LCORE and rte_log_cur_msg_loglevel gives
> default log level as described in commit log. With this patch each
> thread gets its own log level.
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Thanks for reviewing and testing.
Regards,
Olivier
next prev parent reply other threads:[~2016-05-12 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 16:13 Olivier Matz
2016-05-11 16:39 ` Ferruh Yigit
2016-05-12 9:22 ` Olivier MATZ [this message]
2016-05-17 15:56 ` David Marchand
2016-05-18 14:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57344B45.1070702@6wind.com \
--to=olivier.matz@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.leroy@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).