From: Olivier Matz <olivier.matz@6wind.com>
To: Beilei Xing <beilei.xing@intel.com>, jingjing.wu@intel.com
Cc: dev@dpdk.org, Julien Meunier <julien.meunier@6wind.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v3] i40e: configure MTU
Date: Mon, 16 May 2016 14:27:02 +0200 [thread overview]
Message-ID: <5739BC96.5010509@6wind.com> (raw)
In-Reply-To: <1463127333-10007-1-git-send-email-beilei.xing@intel.com>
Hi Beilei,
On 05/13/2016 10:15 AM, Beilei Xing wrote:
> This patch enables configuring MTU for i40e.
> Since changing MTU needs to reconfigure queue, stop port first
> before configuring MTU.
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
> v3 changes:
> Add frame size with extra I40E_VLAN_TAG_SIZE.
> Delete i40e_dev_rx_init(pf) cause it will be called when port starts.
>
> v2 changes:
> If mtu is not within the allowed range, return -EINVAL instead of -EBUSY.
> Delete rxq reconfigure cause rxq reconfigure will be finished in
> i40e_dev_rx_init.
>
> drivers/net/i40e/i40e_ethdev.c | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> [...]
> +static int
> +i40e_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
> +{
> + struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> + struct rte_eth_dev_data *dev_data = pf->dev_data;
> + uint32_t frame_size = mtu + ETHER_HDR_LEN
> + + ETHER_CRC_LEN + I40E_VLAN_TAG_SIZE;
> + int ret = 0;
> +
> + /* check if mtu is within the allowed range */
> + if ((mtu < ETHER_MIN_MTU) || (frame_size > I40E_FRAME_SIZE_MAX))
> + return -EINVAL;
> +
> + /* mtu setting is forbidden if port is start */
> + if (dev_data->dev_started) {
> + PMD_DRV_LOG(ERR,
> + "port %d must be stopped before configuration\n",
> + dev_data->port_id);
> + return -ENOTSUP;
> + }
I'm not convinced that ENOTSUP is the proper return value here.
It is usually returned when a function is not implemented, which
is not the case here: the function is implemented but is forbidden
because the port is running.
I saw that Julien commented on your v1 that the return value should
be one of:
- (0) if successful.
- (-ENOTSUP) if operation is not supported.
- (-ENODEV) if *port_id* invalid.
- (-EINVAL) if *mtu* invalid.
But I think your initial value (-EBUSY) was fine. Maybe it should be
added in the API instead, with the following description:
(-EBUSY) if the operation is not allowed when the port is running
This would allow the application to take its dispositions to stop the
port and restart it with the proper jumbo_frame argument.
+CC Thomas which maintains ethdev API.
Regards,
Olivier
next prev parent reply other threads:[~2016-05-16 12:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-23 11:26 [dpdk-dev] [PATCH] " Beilei Xing
2016-04-26 2:00 ` Wu, Jingjing
2016-04-27 11:43 ` Julien Meunier
2016-04-27 15:01 ` Xing, Beilei
2016-04-28 3:19 ` [dpdk-dev] [PATCH V2] " Beilei Xing
2016-05-13 8:15 ` [dpdk-dev] [PATCH v3] " Beilei Xing
2016-05-16 12:27 ` Olivier Matz [this message]
2016-06-16 17:40 ` Yong Wang
2016-06-16 17:51 ` Yong Wang
2016-06-17 0:03 ` Ananyev, Konstantin
2016-06-20 4:49 ` Xing, Beilei
2016-06-20 4:59 ` Xing, Beilei
2016-06-20 8:05 ` Ananyev, Konstantin
2016-06-20 12:04 ` Xing, Beilei
2016-06-20 12:15 ` Ananyev, Konstantin
2016-06-20 12:46 ` Xing, Beilei
2016-05-20 15:17 ` [dpdk-dev] [PATCH v4] " Beilei Xing
2016-05-23 1:33 ` Wu, Jingjing
2016-06-09 14:23 ` Bruce Richardson
2016-06-23 10:13 ` Bruce Richardson
2016-06-23 13:37 ` Xing, Beilei
2016-06-23 13:44 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5739BC96.5010509@6wind.com \
--to=olivier.matz@6wind.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=julien.meunier@6wind.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).