From: Olivier Matz <olivier.matz@6wind.com>
To: Jingjing Wu <jingjing.wu@intel.com>, helin.zhang@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] mbuf: new NSH packet type
Date: Thu, 19 May 2016 14:26:54 +0200 [thread overview]
Message-ID: <573DB10E.3050300@6wind.com> (raw)
In-Reply-To: <1462254672-6563-2-git-send-email-jingjing.wu@intel.com>
Hi Jingjing,
On 05/03/2016 07:51 AM, Jingjing Wu wrote:
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
> lib/librte_mbuf/rte_mbuf.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index 529debb..79edae3 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -274,6 +274,13 @@ extern "C" {
> */
> #define RTE_PTYPE_L2_ETHER_LLDP 0x00000004
> /**
> + * NSH (Network Service Header) packet type.
> + *
> + * Packet format:
> + * <'ether type'=0x894F>
> + */
> +#define RTE_PTYPE_L2_ETHER_NSH 0x00000005
> +/**
> * Mask of layer 2 packet types.
> * It is used for outer packet for tunneling cases.
> */
>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
I have no objection for this patch, but it makes me think about
2 things:
- we have the room for 16 types for each layer, maybe we should
start to be careful about which types should be supported to
avoid running out of types in the future.
- The types supported in outer and inner have diverged. It would
have been better to have something like:
#define RTE_PTYPE_INNER_$type (RTE_PTYPE_$type << 16)
Because it would make the software using the packet types
simpler.
It's maybe a bit late now because it would break the ABI, but
this is something we could keep in mind in case we change the
ABI for another reason.
Regards,
Olivier
next prev parent reply other threads:[~2016-05-19 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 5:51 [dpdk-dev] [PATCH 0/2] NSH packet type support in i40e Jingjing Wu
2016-05-03 5:51 ` [dpdk-dev] [PATCH 1/2] mbuf: new NSH packet type Jingjing Wu
2016-05-19 12:26 ` Olivier Matz [this message]
2016-05-26 8:41 ` Pei, Yulong
2016-05-03 5:51 ` [dpdk-dev] [PATCH 2/2] i40e: NSH packet type support Jingjing Wu
2016-06-01 18:39 ` [dpdk-dev] [PATCH 0/2] NSH packet type support in i40e Zhe Tao
2016-06-23 19:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573DB10E.3050300@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).