From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 0/6] query hash key size in byte
Date: Thu, 09 Jul 2015 01:17:11 +0200 [thread overview]
Message-ID: <57456880.mAaSW7tfxi@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836A08EFD@irsmsx105.ger.corp.intel.com>
> > As different hardware has different hash key sizes, querying it (in byte)
> > per port was asked by users. Otherwise there is no convenient way to know
> > the size of hash key which should be prepared.
> >
> > v2 changes:
> > * Disabled the code changes by default, to avoid breaking ABI compatibility.
> >
> > v3 changes:
> > * Moved the newly added element right after 'uint16_t reta_size', where it
> > was a padding. So it will not break any ABI compatibility, and no need to
> > disable the code changes by default.
> >
> > Helin Zhang (6):
> > ethdev: add an field for querying hash key size
> > e1000: fill the hash key size
> > fm10k: fill the hash key size
> > i40e: fill the hash key size
> > ixgbe: fill the hash key size
> > app/testpmd: show the hash key size
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks
It is assumed that inserting a new field in a padding alignment won't break
the ABI.
prev parent reply other threads:[~2015-07-08 23:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 1:00 [dpdk-dev] [PATCH " Helin Zhang
2015-06-04 1:00 ` [dpdk-dev] [PATCH 1/6] ethdev: add an field for querying hash key size Helin Zhang
2015-06-04 13:05 ` Neil Horman
2015-06-05 6:21 ` Zhang, Helin
2015-06-05 10:30 ` Neil Horman
2015-06-04 1:00 ` [dpdk-dev] [PATCH 2/6] e1000: fill the " Helin Zhang
2015-06-04 1:00 ` [dpdk-dev] [PATCH 3/6] fm10k: " Helin Zhang
2015-06-04 1:00 ` [dpdk-dev] [PATCH 4/6] i40e: " Helin Zhang
2015-06-04 1:00 ` [dpdk-dev] [PATCH 5/6] ixgbe: " Helin Zhang
2015-06-04 1:00 ` [dpdk-dev] [PATCH 6/6] app/testpmd: show " Helin Zhang
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 0/6] query hash key size in byte Helin Zhang
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 1/6] ethdev: add an field for querying hash key size Helin Zhang
2015-06-04 10:38 ` Ananyev, Konstantin
2015-06-12 6:06 ` Zhang, Helin
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 2/6] e1000: fill the " Helin Zhang
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 3/6] fm10k: " Helin Zhang
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 4/6] i40e: " Helin Zhang
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 5/6] ixgbe: " Helin Zhang
2015-06-04 7:33 ` [dpdk-dev] [PATCH v2 6/6] app/testpmd: show " Helin Zhang
2015-06-12 7:33 ` [dpdk-dev] [PATCH v3 0/6] query hash key size in byte Helin Zhang
2015-06-12 7:33 ` [dpdk-dev] [PATCH v3 1/6] ethdev: add an field for querying hash key size Helin Zhang
2015-06-15 15:01 ` Thomas Monjalon
2015-06-12 7:33 ` [dpdk-dev] [PATCH v3 2/6] e1000: fill the " Helin Zhang
2015-06-12 7:33 ` [dpdk-dev] [PATCH v3 3/6] fm10k: " Helin Zhang
2015-06-12 7:33 ` [dpdk-dev] [PATCH v3 4/6] i40e: " Helin Zhang
2015-06-12 7:34 ` [dpdk-dev] [PATCH v3 5/6] ixgbe: " Helin Zhang
2015-06-12 7:34 ` [dpdk-dev] [PATCH v3 6/6] app/testpmd: show " Helin Zhang
2015-06-12 9:31 ` [dpdk-dev] [PATCH v3 0/6] query hash key size in byte Ananyev, Konstantin
2015-07-08 23:17 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57456880.mAaSW7tfxi@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).