From: Thomas Monjalon <thomas@monjalon.net>
To: Wei Dai <wei.dai@intel.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, harish.patil@cavium.com,
rasesh.mody@cavium.com, stephen.hurd@broadcom.com,
ajit.khaparde@broadcom.com, helin.zhang@intel.com,
konstantin.ananyev@intel.com, jingjing.wu@intel.com,
jing.d.chen@intel.com, adrien.mazarguil@6wind.com,
nelio.laranjeiro@6wind.com, bruce.richardson@intel.com,
yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com,
shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com,
john.miller@atomicrules.com
Subject: Re: [dpdk-dev] [PATCH v7 2/3] doc: change type of return value of adding MAC addr
Date: Fri, 05 May 2017 16:23:03 +0200 [thread overview]
Message-ID: <5751614.JobCQIIaUB@xps> (raw)
In-Reply-To: <1493944802-52943-3-git-send-email-wei.dai@intel.com>
05/05/2017 02:40, Wei Dai:
> Add following lines in section of API change in release note.
>
> If a MAC address fails to be added without this change, it is still
> stored and may be regarded as a valid one. This may lead to errors
> in application. The type of return value of eth_mac_addr_add_t in
> rte_ethdev.h is changed. Any specific NIC also follows this change.
>
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>
This patch is rejected because it is neither an API nor an ABI change.
next prev parent reply other threads:[~2017-05-05 14:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-30 4:11 [dpdk-dev] [PATCH v5 0/3] MAC address fail to be added shouldn't be stored Wei Dai
2017-04-30 4:11 ` [dpdk-dev] [PATCH v5 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-04-30 4:11 ` [dpdk-dev] [PATCH v5 2/3] doc: change type of return value of adding " Wei Dai
2017-04-30 4:11 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
2017-04-30 22:59 ` [dpdk-dev] [PATCH v5 0/3] MAC address fail to be added shouldn't be stored Thomas Monjalon
2017-05-02 12:44 ` [dpdk-dev] [PATCH v6 " Wei Dai
2017-05-02 12:44 ` [dpdk-dev] [PATCH v6 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-05-03 0:57 ` Lu, Wenzhuo
2017-05-03 1:46 ` Yuanhan Liu
2017-05-05 0:16 ` Dai, Wei
2017-05-02 12:44 ` [dpdk-dev] [PATCH v6 2/3] doc: change type of return value of adding " Wei Dai
2017-05-02 12:44 ` [dpdk-dev] [PATCH v6 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
2017-05-05 0:39 ` [dpdk-dev] [PATCH v7 0/3] MAC address fail to be added shouldn't be stored Wei Dai
2017-05-05 0:40 ` [dpdk-dev] [PATCH v7 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-05-05 1:46 ` Yang, Qiming
2017-05-05 14:07 ` Thomas Monjalon
2017-05-05 14:21 ` Thomas Monjalon
2017-05-07 4:39 ` Yuanhan Liu
2017-05-05 14:24 ` Thomas Monjalon
2017-05-05 0:40 ` [dpdk-dev] [PATCH v7 2/3] doc: change type of return value of adding " Wei Dai
2017-05-05 14:23 ` Thomas Monjalon [this message]
2017-05-05 0:40 ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
2017-05-05 14:24 ` Thomas Monjalon
2017-05-08 1:01 ` Wu, Jingjing
2017-05-08 6:17 ` Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5751614.JobCQIIaUB@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ed.czeck@atomicrules.com \
--cc=harish.patil@cavium.com \
--cc=helin.zhang@intel.com \
--cc=jing.d.chen@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.miller@atomicrules.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=rasesh.mody@cavium.com \
--cc=shepard.siegel@atomicrules.com \
--cc=stephen.hurd@broadcom.com \
--cc=wei.dai@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).