DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	Simon Kagstrom <simon.kagstrom@netinsight.net>
Cc: olivier.matz@6wind.com, dev@dpdk.org
Subject: Re: [dpdk-dev] PATCH] mbuf: rte_pktmbuf_dump: don't add 0x when using %p in format strings
Date: Tue, 21 Jun 2016 14:11:28 +0100	[thread overview]
Message-ID: <57693D00.5090400@intel.com> (raw)
In-Reply-To: <20160620091940.75a37c54@xeon-e3>

On 6/20/2016 5:19 PM, Stephen Hemminger wrote:
> On Mon, 20 Jun 2016 12:44:35 +0200
> Simon Kagstrom <simon.kagstrom@netinsight.net> wrote:
> 
>> I.e., avoid dump messages with double 0x0x, e.g.,
>>
>>   dump mbuf at 0x0x7fac7b17c800, phys=17b17c880, buf_len=2176
>>     pkt_len=2064, ol_flags=0, nb_segs=1, in_port=255
>>     segment at 0x0x7fac7b17c800, data=0x0x7fac7b17c8f0, data_len=2064
>>
>> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> 
> Agreed. Many other places have same glitch.
> 

Hi Simon,

Are you planning to extend your patch to fix all, or I can send a patch
for kni and vmxnet3?

Thanks,
ferruh

  reply	other threads:[~2016-06-21 13:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20 10:44 Simon Kagstrom
2016-06-20 16:19 ` Stephen Hemminger
2016-06-21 13:11   ` Ferruh Yigit [this message]
2016-06-22  7:08     ` Simon Kågström
2016-06-23 10:52       ` [dpdk-dev] [PATCH] vmxnet3: remove 0x prefix for %p format Ferruh Yigit
2016-06-23 20:45         ` Yong Wang
2016-06-24 16:44           ` Bruce Richardson
2016-06-23 10:58       ` [dpdk-dev] PATCH] mbuf: rte_pktmbuf_dump: don't add 0x when using %p in format strings Ferruh Yigit
2016-06-23 21:26 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57693D00.5090400@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=simon.kagstrom@netinsight.net \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).