From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Ivan Malov <Ivan.Malov@oktetlabs.ru>,
Harry Van Haaren <harry.van.haaren@intel.com>,
Lee Daly <lee.daly@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/3] ethdev: fix xstats get by id APIS
Date: Tue, 24 Oct 2017 00:20:56 +0200 [thread overview]
Message-ID: <5793948.vro8kvxJTo@xps> (raw)
In-Reply-To: <20171020000351.57868-2-ferruh.yigit@intel.com>
20/10/2017 02:03, Ferruh Yigit:
> ethdev xstat get by id APIs:
> rte_eth_xstats_get_names_by_id()
> rte_eth_xstats_get_by_id()
>
> Works on ids calculated as "basic stats + device specific stats"
>
> When an application asking for id less than "basic stats count", it is
> indeed asking basic stats nothing specific to device stats.
>
> The dev_ops PMDs implements xstats_get_names_by_id and xstats_get_by_id
> works on device specific ids.
>
> This patch adds a check if all stats requested by ids can be provided
> via device and if so converts ids to device specific ones.
>
> This conversion wasn't required before commit 8c49d5f1c219, because
> _by_id dev_ops were always used to get whole stats instead of specific
> ids.
>
> Fixes: 8c49d5f1c219 ("ethdev: rework xstats retrieve by id")
It would be easier to understand if starting with a statement of bug.
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -1644,6 +1644,7 @@ rte_eth_xstats_get_names_by_id(uint16_t port_id,
> uint64_t *ids)
> {
> struct rte_eth_xstat_name *xstats_names_copy;
> + unsigned int all_ids_from_pmd = 1;
This variable would be better renamed as "no_basic_stat_requested".
> + ids_copy[i] = ids[i] - basic_count;
This line may deserve a comment.
next prev parent reply other threads:[~2017-10-23 22:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 0:03 [dpdk-dev] [PATCH 1/3] ethdev: extract xstat basic stat count calculation Ferruh Yigit
2017-10-20 0:03 ` [dpdk-dev] [PATCH 2/3] ethdev: fix xstats get by id APIS Ferruh Yigit
2017-10-20 12:33 ` Ivan Malov
2017-10-23 22:20 ` Thomas Monjalon [this message]
2017-10-20 0:03 ` [dpdk-dev] [PATCH 3/3] ethdev: fix negative return values in xstats Ferruh Yigit
2017-10-23 22:26 ` Thomas Monjalon
2017-10-23 23:12 ` [dpdk-dev] [PATCH 1/3] ethdev: extract xstat basic stat count calculation Ferruh Yigit
2017-10-23 23:12 ` [dpdk-dev] [PATCH 2/3] ethdev: fix xstats get by id APIS Ferruh Yigit
2017-10-23 23:12 ` [dpdk-dev] [PATCH 3/3] ethdev: check more errors in xstats retrieval Ferruh Yigit
2017-10-23 23:15 ` [dpdk-dev] [PATCH v2 1/3] ethdev: extract xstat basic stat count calculation Ferruh Yigit
2017-10-23 23:15 ` [dpdk-dev] [PATCH v2 2/3] ethdev: fix xstats get by id APIS Ferruh Yigit
2017-10-23 23:33 ` Thomas Monjalon
2017-10-23 23:15 ` [dpdk-dev] [PATCH v2 3/3] ethdev: check more errors in xstats retrieval Ferruh Yigit
2017-10-24 0:31 ` [dpdk-dev] [PATCH v2 1/3] ethdev: extract xstat basic stat count calculation Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5793948.vro8kvxJTo@xps \
--to=thomas@monjalon.net \
--cc=Ivan.Malov@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=lee.daly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).