From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Wei Dai <wei.dai@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 4/4] eal: fix end character check in --lcores argument
Date: Thu, 28 Jul 2016 16:26:43 +0100 [thread overview]
Message-ID: <579A2433.1060701@intel.com> (raw)
In-Reply-To: <1469618870-144592-1-git-send-email-wei.dai@intel.com>
On 7/27/2016 12:27 PM, Wei Dai wrote:
> With --lcores 'a-b@c-d', eal_parse_cores() fails because
> eal_parse_set() fails due to the next character after
> lcore set a-b, which is '@'and not ',' or '\0'.
> There is also a right check immediately
> after this incorrect check.
>
> Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment")
>
> Signed-off-by: Wei Dai <wei.dai@intel.com>
I am not sure if a-b@c-d syntax should be supported. (a-b)@(c-d) is
supported and already working.
It looks like a-b is only planned to use without @
and the usage a-b@c-d, like 1-2@4-5 implies to me:
1 -> 4
2 -> 5
but it doesn't work that way, it is always grouped after @, like it has
parenthesis, what it does is:
1 -> 4,5
2 -> 4,5
Even a-b@c is not working, but as I said if @ will be used, using
grouping seems more proper to me, like:
(a-b)@(c-d)
(a-b)@c
So this is mainly about defining the syntax, more than implementing it.
Somebody know more about syntax can comment better.
Regards,
ferruh
next prev parent reply other threads:[~2016-07-28 15:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 6:03 [dpdk-dev] [PATCH] eal: fix parsing of argument of option --lcores Wei Dai
2016-07-21 14:21 ` Thomas Monjalon
2016-07-21 20:44 ` bynes adam
2016-07-27 10:06 ` Dai, Wei
2016-07-26 9:52 ` [dpdk-dev] [PATCH v2 1/2] eal: remove redundant codes to parse --lcores Wei Dai
2016-07-26 11:51 ` Ananyev, Konstantin
2016-07-26 17:36 ` Adam Bynes
2016-07-27 9:15 ` Dai, Wei
2016-07-27 11:22 ` [dpdk-dev] [PATCH v3 1/4] " Wei Dai
2016-07-28 15:18 ` Ferruh Yigit
2016-07-27 11:25 ` [dpdk-dev] [PATCH v3 3/4] eal: fix tail blank check in --lcores argument Wei Dai
2016-07-28 15:18 ` Ferruh Yigit
2016-07-26 9:52 ` [dpdk-dev] [PATCH v2 2/2] eal: fix parsing of eal option --lcores Wei Dai
2016-07-27 11:23 ` [dpdk-dev] [PATCH v3 2/4] " Wei Dai
2016-07-28 15:18 ` Ferruh Yigit
2016-07-27 11:27 ` [dpdk-dev] [PATCH v3 4/4] eal: fix end character check in --lcores argument Wei Dai
2016-07-28 15:26 ` Ferruh Yigit [this message]
2016-07-28 16:05 ` Thomas Monjalon
2016-08-02 8:22 ` Dai, Wei
2016-08-02 10:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579A2433.1060701@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).