From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org, Stephen Hurd <stephen.hurd@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: make driver less verbose
Date: Fri, 26 Aug 2016 09:39:41 +0100 [thread overview]
Message-ID: <57C0004D.8030706@intel.com> (raw)
In-Reply-To: <CACZ4nhvdQmQ1vq7p9-peDEBeEgQfx4vRsnZQw=RVG5ghGKCZbA@mail.gmail.com>
On 8/25/2016 8:03 PM, Ajit Khaparde wrote:
>
>
> On Thu, Aug 25, 2016 at 6:05 AM, Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
>
> This line printed for every application even if driver is not used at
> all. Removing the line to reduce the noise.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>>
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index 3795fac..37d0322 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -1056,7 +1056,6 @@ static struct eth_driver bnxt_rte_pmd = {
>
> static int bnxt_rte_pmd_init(const char *name, const char *params
> __rte_unused)
> {
> - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name);
>
> How about changing the log level to DEBUG?
>
> - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name);
> + RTE_LOG(DEBUG, PMD, "bnxt_rte_pmd_init() called for %s\n", name);
>
> That should reduce the noise till the user explicitly changes the log level.
This will give similar result, this log is useless if you are not
debugging this driver, but debug log level can be enabled for many reasons.
Other drivers use PMD_INIT_FUNC_TRACE() macros, which requires
specifically enabled in config for that driver.
>
> Thanks
>
>
>
> rte_eth_driver_register(&bnxt_rte_pmd);
> return 0;
> }
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2016-08-26 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 11:05 Ferruh Yigit
2016-08-25 19:03 ` Ajit Khaparde
2016-08-26 8:39 ` Ferruh Yigit [this message]
2016-08-26 15:31 ` Ajit Khaparde
2016-09-11 12:25 ` Yuanhan Liu
2016-09-12 14:23 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-09-19 15:04 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C0004D.8030706@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=stephen.hurd@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).