From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Vincent Guo <guopengfei160@163.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Bug fix in module_init and module_exit
Date: Mon, 29 Aug 2016 10:38:51 +0100 [thread overview]
Message-ID: <57C402AB.6000907@intel.com> (raw)
In-Reply-To: <57C40200.6020009@intel.com>
On 8/29/2016 10:36 AM, Ferruh Yigit wrote:
> Hi Vincent,
>
> On 8/29/2016 3:12 AM, Vincent Guo wrote:
>> Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set.
>>
>> Signed-off-by: Vincent Guo <guopengfei160@163.com>
>> ---
>
> Thank you for the update, patch applies well this time.
>
> A few more small details:
>
> - Patch subject should start with a label/tag, that shows the
> corresponding subsystem. For this patch it is "kni:".
>
> - In patch subject, after label, sentences starts with lowercase, so
> patch subject becomes:
>
> kni: bug fix in module_init and module_exit
>
>
> - "Fixes:" tag is a line in commit log, to reference the commit that
> generated the error. For this patch it is:
>
> Fixes: e6734d21b4e1 ("kni: fix build with kernel 2.6.32")
>
> This line should go above "Signed-off-by", with an empty line between.
>
> - Replying to previous mail thread help others to see the history of the
> patch. the option --in-reply-to of the "git send-email" can be used for
> this.
>
> It is possible to get Message ID of the mail that you want to reply via
> patchwork or from mail client. For example for this patch, you can see
> the message id from: http://dpdk.org/dev/patchwork/patch/15506/
>
> - Adding version number to the patch helps following history. Each
> updated patch increases the version number. "-vN" option of the "git
> format-patch" is useful for this.
>
> - When a new version of the patch sent, the status of the previous
> version should be updated in patchwork as "Superseded". For this case
> previous version is: http://dpdk.org/dev/patchwork/patch/15506/
Correction: http://dpdk.org/dev/patchwork/patch/15315/
>
>
> Thanks,
> ferruh
>
next prev parent reply other threads:[~2016-08-29 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 2:12 Vincent Guo
2016-08-29 9:36 ` Ferruh Yigit
2016-08-29 9:38 ` Ferruh Yigit [this message]
2016-09-02 10:23 ` [dpdk-dev] [PATCH v2] kni: " Vincent Guo
2016-09-06 8:02 ` Ferruh Yigit
2016-09-09 14:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C402AB.6000907@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=guopengfei160@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).