From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Arnon Warshavsky <arnon@qwilt.com>,
thomas@monjalon.net, wenzhuo.lu@intel.com,
declan.doherty@intel.com, jerin.jacob@caviumnetworks.com,
bruce.richardson@intel.com, ferruh.yigit@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 00/13] eal: replace calls to rte_panic and refrain from new instances
Date: Fri, 13 Apr 2018 10:16:18 +0100 [thread overview]
Message-ID: <57cadbf8-26b4-d449-6c06-5ff2fe92c12f@intel.com> (raw)
In-Reply-To: <1522879294-8803-1-git-send-email-arnon@qwilt.com>
On 04-Apr-18 11:01 PM, Arnon Warshavsky wrote:
>
> The purpose of this patch series is to cleanup the library code
> from paths that end up aborting the process,
> and move to checking error values, in order to allow the running process
> perform an orderly teardown or other mitigation of the event.
>
> This patch modifies the majority of rte_panic calls
> under lib and drivers, and replaces them with a log message
> and an error return code according to context,
> that can be propagated up the call stack.
>
> - Focus was given to the dpdk initialization path
> - Some of the panic calls within drivers were left in place where
> the call is from within an interrupt or calls that are
> on the data path,where there is no simple applicative
> route to propagate the error to temination.
> These should be handled by the driver maintainers.
> - In order to avoid breaking ABI where panic was called from public
> void functions, a panic state variable was introduced so that
> it can be queried after calling these void functions.
> This tool place for a single function call.
> - local void functions with no api were changed to retrun a value
> where needed
> - No change took place in example and test files
> - No change took place for debug assertions calling panic
> - A new function was added to devtools/checkpatches.sh
> in order to prevent new additions of calls to rte_panic
> under lib and drivers.
>
> Keep calm and don't panic
>
> ---
>
> v2:
> - reformat error messages so that literal string are in the same line
> - fix typo in commit message
> - add new return code to doxigen of rte_memzone_free()
Hi Arnon,
When sending new versions, the entire patchset must be sent. It makes it
easier for maintainers to apply patches this way.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-04-13 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 22:01 Arnon Warshavsky
2018-04-04 22:01 ` [dpdk-dev] [PATCH v2 09/13] eal: replace rte_panic instances in common_memzone Arnon Warshavsky
2018-04-04 22:01 ` [dpdk-dev] [PATCH v2 01/13] crypto: replace rte_panic instances in crypto driver Arnon Warshavsky
2018-04-13 9:16 ` Burakov, Anatoly [this message]
2018-04-13 18:21 ` [dpdk-dev] [PATCH v2 00/13] eal: replace calls to rte_panic and refrain from new instances Arnon Warshavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57cadbf8-26b4-d449-6c06-5ff2fe92c12f@intel.com \
--to=anatoly.burakov@intel.com \
--cc=arnon@qwilt.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).