From: linhaifeng <haifeng.lin@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>,
<declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bonding: not handle vlan slow packet
Date: Tue, 1 Nov 2016 20:32:38 +0800 [thread overview]
Message-ID: <58188B66.2050108@huawei.com> (raw)
In-Reply-To: <227a3391-019d-3a4c-e76f-d1775466261b@intel.com>
在 2016/11/1 18:46, Ferruh Yigit 写道:
> Hi Haifeng,
>
> On 10/31/2016 3:52 AM, linhaifeng wrote:
>> From: Haifeng Lin <haifeng.lin@huawei.com>
>>
>> if rx vlan offload is enable we should not handle vlan slow
>> packets too.
>>
>> Signed-off-by: Haifeng Lin <haifeng.lin@huawei.com>
>> ---
>> drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
>> index 09ce7bf..ca17898 100644
>> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
>> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
>> @@ -169,7 +169,8 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
>> /* Remove packet from array if it is slow packet or slave is not
>> * in collecting state or bondign interface is not in promiscus
>> * mode and packet address does not match. */
>> - if (unlikely(hdr->ether_type == ether_type_slow_be ||
>> + if (unlikely((hdr->ether_type == ether_type_slow_be &&
>> + !bufs[j]->vlan_tci) ||
>> !collecting || (!promisc &&
>> !is_multicast_ether_addr(&hdr->d_addr) &&
>> !is_same_ether_addr(&bond_mac, &hdr->d_addr)))) {
>>
>
> There are a few version of this patch, I guess this one is the correct
> one, can you please confirm?
> Also this one supersede following one, right?
> http://dpdk.org/dev/patchwork/patch/16840/
yes,this is
>
> It helps a lot if you use versioning in the patches [PATCH -vN] and add
> a description of changes in commit log (after "---") between patch versions.
>
ok,i think should not send patch so worry:)
I have a question to ask:
Is there any other packets' type also is 0x8809 except with lacp packets?
I saw some guests try to use this type to check link status between VM
but droped by lacp bond recv function.
> Thanks,
> ferruh
>
> .
>
next prev parent reply other threads:[~2016-11-01 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 3:52 linhaifeng
2016-11-01 10:46 ` Ferruh Yigit
2016-11-01 12:32 ` linhaifeng [this message]
2016-11-04 3:16 ` linhaifeng
-- strict thread matches above, loose matches on Subject: below --
2016-10-31 2:39 linhaifeng
2016-10-31 1:34 linhaifeng
2016-10-28 2:57 linhaifeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58188B66.2050108@huawei.com \
--to=haifeng.lin@huawei.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).