From: John Griffin <john.griffin@intel.com>
To: Fiona Trahe <fiona.trahe@intel.com>, dev@dpdk.org
Cc: pablo.de.lara.guarch@intel.com, michalx.k.jastrzebski@intel.com,
arkadiuszx.kusztal@intel.com
Subject: Re: [dpdk-dev] [PATCH] crypto: remove unused digest-appended feature
Date: Fri, 18 Nov 2016 18:15:59 +0000 [thread overview]
Message-ID: <582F455F.3030505@intel.com> (raw)
In-Reply-To: <1479403997-15437-2-git-send-email-fiona.trahe@intel.com>
On 17/11/16 17:33, Fiona Trahe wrote:
> The cryptodev API had specified that if the digest address field was
> left empty on an authentication operation, then the PMD would assume
> the digest was appended to the source or destination data.
> This case was not handled at all by most PMDs and incorrectly handled
> by the QAT PMD.
> As no bugs were raised, it is assumed to be not needed, so this patch
> removes it, rather than add handling for the case on all PMDs.
> The digest can still be appended to the data, but its
> address must now be provided in the op.
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
> drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
> drivers/crypto/qat/qat_crypto.c | 18 +-----------------
> lib/librte_cryptodev/rte_crypto_sym.h | 10 +---------
> 3 files changed, 4 insertions(+), 26 deletions(-)
>
Acked-by: John Griffin <john.griffin@intel.com>
next prev parent reply other threads:[~2016-11-18 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 17:33 Fiona Trahe
2016-11-17 17:33 ` Fiona Trahe
2016-11-18 18:15 ` John Griffin [this message]
2016-11-30 15:16 ` De Lara Guarch, Pablo
2016-11-17 17:52 ` Trahe, Fiona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582F455F.3030505@intel.com \
--to=john.griffin@intel.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=michalx.k.jastrzebski@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).