DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Cc: Scott Branden <scott.branden@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: convert to SPDX license tag
Date: Mon, 26 Mar 2018 12:58:28 +0530	[thread overview]
Message-ID: <59227a6c-af78-e6fa-e74a-0955b1700a65@nxp.com> (raw)
In-Reply-To: <20180325190757.19751-1-ajit.khaparde@broadcom.com>

Hi Ajit/Scott,


On 3/26/2018 12:37 AM, Ajit Khaparde wrote:
> From: Scott Branden <scott.branden@broadcom.com>
>
> Update the license header on bnxt files to be the standard
> BSD-3-Clause license used for the rest of DPDK,
> bring the files in compliance with the DPDK licensing policy.
>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
> index b5a0badfc..967c94d14 100644
> --- a/drivers/net/bnxt/bnxt.h
> +++ b/drivers/net/bnxt/bnxt.h
> @@ -1,34 +1,7 @@
> -/*-
> - *   BSD LICENSE
> - *
> - *   Copyright(c) Broadcom Limited.
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + *   Copyright(c) 2014-2018 Broadcom
>    *   All rights reserved.
> - *
> - *   Redistribution and use in source and binary forms, with or without
> - *   modification, are permitted provided that the following conditions
> - *   are met:
> - *
> - *     * Redistributions of source code must retain the above copyright
> - *       notice, this list of conditions and the following disclaimer.
> - *     * Redistributions in binary form must reproduce the above copyright
> - *       notice, this list of conditions and the following disclaimer in
> - *       the documentation and/or other materials provided with the
> - *       distribution.
> - *     * Neither the name of Broadcom Corporation nor the names of its
> - *       contributors may be used to endorse or promote products derived
> - *       from this software without specific prior written permission.
> - *
> - *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> - *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> - *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> - *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> - *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> - *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> - *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> - *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> - *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> - *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> - *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>    */
>   
>   #ifndef _BNXT_H_
> diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c
> index 737bb060a..bb57c6f4f 100644
> --- a/drivers/net/bnxt/bnxt_cpr.c
> +++ b/drivers/net/bnxt/bnxt_cpr.c
> @@ -1,34 +1,7 @@
> -/*-
> - *   BSD LICENSE
> - *
> - *   Copyright(c) Broadcom Limited.
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + *   Copyright(c) 2014-2018 Broadcom
>    *   All rights reserved.
>
It is preferred to use  "/*" commenting instead of "//" in dpdk for 
first line SPDX identifer.
It will maintain the consistency and help in future automation for 
license check.

Regards,
Hemant

  reply	other threads:[~2018-03-26  7:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-25 19:07 Ajit Khaparde
2018-03-26  7:28 ` Hemant Agrawal [this message]
     [not found]   ` <3f4ea1f2-023e-46f8-96e2-e7380ed5f3c2@broadcom.com>
2018-03-27  6:51     ` Hemant Agrawal
2018-03-29 16:40       ` [dpdk-dev] [PATCH v2] " Ajit Khaparde
2018-03-30 10:35         ` Ferruh Yigit
2018-03-30 18:10           ` Scott Branden
2018-03-31 21:08             ` Ferruh Yigit
2018-04-02 18:57               ` Scott Branden
2018-04-02 22:34                 ` [dpdk-dev] [PATCH v3] " Ajit Khaparde
2018-04-03  6:29                   ` Hemant Agrawal
2018-04-05 14:40                     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59227a6c-af78-e6fa-e74a-0955b1700a65@nxp.com \
    --to=hemant.agrawal@nxp.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=scott.branden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).