From: Declan Doherty <declan.doherty@intel.com>
To: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 1/1] examples/l2fwd-crypto: improve random key generator
Date: Wed, 13 Jul 2016 16:55:43 +0100 [thread overview]
Message-ID: <592ce77e-576f-d17d-d0b6-c9caed081c3c@intel.com> (raw)
In-Reply-To: <1464183292-24280-1-git-send-email-piotrx.t.azarewicz@intel.com>
On 05/25/2016 02:34 PM, Piotr Azarewicz wrote:
> This patch improve generate_random_key() function by replacing rand()
> function with reading from /dev/urandom.
>
> CID 120136 : Calling risky function (DC.WEAK_CRYPTO)
> dont_call: rand should not be used for security related applications, as
> linear congruential algorithms are too easy to break
>
> Coverity issue: 120136
>
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
> ---
> examples/l2fwd-crypto/main.c | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
> index d18c813..e1f0a1e 100644
> --- a/examples/l2fwd-crypto/main.c
> +++ b/examples/l2fwd-crypto/main.c
> @@ -45,6 +45,8 @@
> #include <ctype.h>
> #include <errno.h>
> #include <getopt.h>
> +#include <fcntl.h>
> +#include <unistd.h>
>
> #include <rte_atomic.h>
> #include <rte_branch_prediction.h>
> @@ -581,10 +583,18 @@ l2fwd_simple_forward(struct rte_mbuf *m, unsigned portid)
> static void
> generate_random_key(uint8_t *key, unsigned length)
> {
> - unsigned i;
> + int fd;
> + int ret;
> +
> + fd = open("/dev/urandom", O_RDONLY);
> + if (fd < 0)
> + rte_exit(EXIT_FAILURE, "Failed to generate random key\n");
>
> - for (i = 0; i < length; i++)
> - key[i] = rand() % 0xff;
> + ret = read(fd, key, length);
> + close(fd);
> +
> + if (ret != (signed)length)
> + rte_exit(EXIT_FAILURE, "Failed to generate random key\n");
> }
>
> static struct rte_cryptodev_sym_session *
> @@ -1180,8 +1190,6 @@ l2fwd_crypto_parse_timer_period(struct l2fwd_crypto_options *options,
> static void
> l2fwd_crypto_default_options(struct l2fwd_crypto_options *options)
> {
> - srand(time(NULL));
> -
> options->portmask = 0xffffffff;
> options->nb_ports_per_lcore = 1;
> options->refresh_period = 10000;
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2016-07-13 16:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 13:34 Piotr Azarewicz
2016-06-07 20:30 ` Thomas Monjalon
2016-06-08 7:46 ` Azarewicz, PiotrX T
2016-07-11 14:17 ` Thomas Monjalon
2016-07-13 15:54 ` Declan Doherty
2016-07-13 15:55 ` Declan Doherty [this message]
2016-07-15 22:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592ce77e-576f-d17d-d0b6-c9caed081c3c@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=piotrx.t.azarewicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).