From: Akhil Goyal <akhil.goyal@nxp.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
Declan Doherty <declan.doherty@intel.com>
Cc: "Nicolau, Radu" <radu.nicolau@intel.com>,
"aviadye@mellanox.com" <aviadye@mellanox.com>,
"borisp@mellanox.com" <borisp@mellanox.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev and ethdev
Date: Tue, 8 Aug 2017 12:24:39 +0530 [thread overview]
Message-ID: <59307fef-7741-ef82-a646-fa952ab9d54d@nxp.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CBE9031@IRSMSX108.ger.corp.intel.com>
Hi Pablo/Declan,
On 8/4/2017 8:55 PM, De Lara Guarch, Pablo wrote:
>
>
>> -----Original Message-----
>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>> Sent: Thursday, August 3, 2017 4:32 PM
>> To: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>;
>> thomas@monjalon.net; Nicolau, Radu <radu.nicolau@intel.com>;
>> aviadye@mellanox.com; borisp@mellanox.com;
>> hemant.agrawal@nxp.com; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>
>> Cc: Akhil Goyal <akhil.goyal@nxp.com>
>> Subject: [PATCH] doc: announce ABI change for cryptodev and ethdev
>>
>> Support for security operations is planned to be added in ethdev and
>> cryptodev for the 17.11 release.
>>
>> For this following changes are required.
>> - rte_cryptodev and rte_eth_dev structures need to be added new
>> parameter rte_security_ops which extend support for security ops to the
>> corresponding driver.
>> - rte_cryptodev_info and rte_ethd_dev_info need to be added with
>> rte_security_capabilities to identify the capabilities of the corresponding
>> driver.
>>
>> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
>
> Not sure if this needed to be split into two patches, as this affects two libraries.
> At least, from cryptodev side:
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
We would be needing one more ABI change, Can I send it now. I discovered
it after I sent this patch.
In the struct rte_crypto_sym_op, we would need to add a pointer to a
security session in the union of session and xform.
Also, Do I need to split this patch into two for crypto and eth?
Regards,
Akhil
next prev parent reply other threads:[~2017-08-08 6:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 15:32 Akhil Goyal
2017-08-04 5:26 ` Hemant Agrawal
2017-08-07 17:41 ` Thomas Monjalon
2017-08-07 18:07 ` Boris Pismenny
2017-08-08 5:03 ` Shahaf Shuler
2017-08-08 10:00 ` Thomas Monjalon
2017-08-04 9:28 ` De Lara Guarch, Pablo
2017-08-04 15:25 ` De Lara Guarch, Pablo
2017-08-08 6:54 ` Akhil Goyal [this message]
2017-08-08 7:09 ` [dpdk-dev] [PATCH v2] " Akhil Goyal
2017-08-08 8:08 ` De Lara Guarch, Pablo
2017-08-08 8:42 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59307fef-7741-ef82-a646-fa952ab9d54d@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=radu.nicolau@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).